From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F5EC43381 for ; Mon, 25 Mar 2019 00:14:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB9312133F for ; Mon, 25 Mar 2019 00:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729197AbfCYAN6 (ORCPT ); Sun, 24 Mar 2019 20:13:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44706 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729109AbfCYAN6 (ORCPT ); Sun, 24 Mar 2019 20:13:58 -0400 Received: from localhost (unknown [50.233.106.125]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CB023108AE0DE; Sun, 24 Mar 2019 17:13:57 -0700 (PDT) Date: Sun, 24 Mar 2019 20:13:57 -0400 (EDT) Message-Id: <20190324.201357.1580092867848179795.davem@davemloft.net> To: Markus.Amend@telekom.de Cc: gerrit@erg.abdn.ac.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dccp@vger.kernel.org Subject: Re: [PATCH] net: dccp: Checksum verification considering skb->ip_summed From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Mar 2019 17:13:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Date: Fri, 22 Mar 2019 14:34:58 +0000 > @@ -786,7 +787,8 @@ static int dccp_v4_rcv(struct sk_buff *skb) > > iph = ip_hdr(skb); > /* Step 1: If header checksum is incorrect, drop packet and return */ > - if (dccp_v4_csum_finish(skb, iph->saddr, iph->daddr)) { > + if (__skb_checksum_validate(skb, IPPROTO_DCCP, > + true, false, 0, inet_compute_pseudo)) { The arguments on the second and subsequent lines of a function call must begin precisely at the first column after the openning parenthesis of the first line of the function call. You must use the appropriate number of TAB, then SPACE, characters necessary to achieve this.