From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1579AC43381 for ; Sun, 24 Mar 2019 08:12:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5AAE218AC for ; Sun, 24 Mar 2019 08:12:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="2THm3aXk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbfCXIMh (ORCPT ); Sun, 24 Mar 2019 04:12:37 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54848 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfCXIMh (ORCPT ); Sun, 24 Mar 2019 04:12:37 -0400 Received: by mail-wm1-f67.google.com with SMTP id f3so5899556wmj.4 for ; Sun, 24 Mar 2019 01:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lv/rnaL7Fu72Vf8SyQEIR4qFIecH1RSORSw9YOfslo4=; b=2THm3aXka852796jlZm7kUtOUk7wY8heLAK5DGDhddlF8yRmBP+JzVDzfe+KE68NVf Fe/jatPELrTWxsqKcgRx5Xc5ftp8BVBETLa+KuLmWawhX/+Vcogj1lZ69r326K2Xm8eP PlbiuvBMWQBdB+QJLq4kbMmyXZyL9fnJS/+AchdRlfEa5JCIr965671xJiSgzQtFE1WV jNZR17pdO3jDo8txg0Jke07jUOMVph1sv54ptb+tM1JpJPcOX+PHA+AISOLRLzh1+e5e hUpgatlBwJKJwT/Vd12wtK9ljVFlaHsZ5Gxo75rWrM4Xz70w/+Po42336d5py8/h+Z+L j9Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lv/rnaL7Fu72Vf8SyQEIR4qFIecH1RSORSw9YOfslo4=; b=LW3uYaO/Dls/ACAX2ll4CIaX3k50nXwD9WkBJuoXTednbzHIFSWVXgKkfxLH0Yu6Gp ys9jJfi3X4/znuDbu7EcWgbO70bT2fecmUEtASo0TlvBbqgnamiwC5glQUAgpQz0Yjo/ 9Y3x04Y6laaKXA0Gg0HgtJvqJpT7bHFxe/dAy+Wn2Aw38TkzbbT74YL1O438dy4HOHsk QsTlMiz7aVoApPAm2s2/b0uBCQdf8kIZb7fP/jBgKsiHnmKdGhrvOPaWlLRA1lLoP/PM HBCsfxPI2MR42cZwg2TDpwtA86IzqtMpceA7iHNczZHf+pZ/VI7KWOU93kFGh1jwLZ/O oi5w== X-Gm-Message-State: APjAAAXuGycvWdKtsnuQiRF+uMXoXEygHcgylSu3ocOxFk6f/PeIWLjj 03ZjSGQK7yAgxQm/bYMbI1RQdg== X-Google-Smtp-Source: APXvYqwS2Hr5EmTuthXBXj811P6XeIz74iQqxCIJFYRzgKznm9B4CumxPo9zQX09X+CZlcjqh88IuQ== X-Received: by 2002:a1c:2885:: with SMTP id o127mr2051733wmo.135.1553415155065; Sun, 24 Mar 2019 01:12:35 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id f128sm21164734wme.28.2019.03.24.01.12.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 01:12:34 -0700 (PDT) Date: Sun, 24 Mar 2019 09:01:54 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next v2 11/15] nfp: move devlink port type set after netdev registration Message-ID: <20190324080154.GD2327@nanopsycho> References: <20190322165636.1725-1-jiri@resnulli.us> <20190322165636.1725-12-jiri@resnulli.us> <20190323133102.60fceb6e@cakuba.netronome.com> <20190323224750.GC2327@nanopsycho> <20190323200405.4a334368@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190323200405.4a334368@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sun, Mar 24, 2019 at 04:04:05AM CET, jakub.kicinski@netronome.com wrote: >On Sat, 23 Mar 2019 23:47:50 +0100, Jiri Pirko wrote: >> >type setting. I'd rather those calls happened on fully initialized >> >netdev (and port), could you perhaps just take this patch into the >> >> I don't get it, you are commenting cleanup part. On init, the type set >> happens on fully initialized devlink_port and netdev. > >I'm talking about internal nfp API calls, nfp_app_vnic_init() and >nfp_app_vnic_clean() should be called while vNIC is completely >initialized and registered from stack's PoV. netdev, and devlink >port fully initialized and set up. I don't think it matters much, >just an imperfection. Oh, I get it. Will change the order. Thanks.