From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DFFC43381 for ; Sun, 24 Mar 2019 10:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6118E222A7 for ; Sun, 24 Mar 2019 10:14:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="n631+GZ9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728769AbfCXKOz (ORCPT ); Sun, 24 Mar 2019 06:14:55 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56201 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728744AbfCXKOx (ORCPT ); Sun, 24 Mar 2019 06:14:53 -0400 Received: by mail-wm1-f68.google.com with SMTP id o25so6004149wmf.5 for ; Sun, 24 Mar 2019 03:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OWCamds6x1rp/8YfEO9wjNJ/BClz/9xzPkoeXYl4neE=; b=n631+GZ9AZyNIqE+PSlb2eONTPJYtV2ong5KdJEkQwC13RXizgcu+NvBbcYVtU1VTP qKZ3T5cUrLXxGXqFqPxiffi6hVSBxOBunjCalnHqzEBJIEkNQQxfNx1JyEg81Mo+/GtU fNYaL0uPuA1dGpl8V5juktbwGcD4gVSNl9LFoU2R0wS8WvgAXezqqgl9rnoGZW0nRSOy 8KQCUT2a0kNU5T1qFvbi3J9XIFk4017r7Mib4nj9TMa92UxwTQAksJ0p1u7HQ4yfp3ly 2UdR7G8+bsTEwEv0nXBCOXEJqE7weEzqlb+gqos4ApsVV1jeV58fFXmY7qUmokz+Yy7M a/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OWCamds6x1rp/8YfEO9wjNJ/BClz/9xzPkoeXYl4neE=; b=C+tMJiPPoX/4jAZZDdrhFn+MgEbJB55k4xaZX3+qWFp2R+BxcK9A4VScxFsrOExiBv bMG/Cefa3khk+YFS7vCR6W2yRVI4zwKZqw/jMHBYCGAX8FE3mf6GeetYUtThmo3HhNNF soYArInPWHEx+b1Gk8UnQV9OUAFoCz8gR0OXhbeSXbPgNcN+f/FhYvDNgbPC+xeV0qW0 /UuKMODM5dUis+7em0kZffZn7H3NylqksuUedU9Oz+lTaqqQL+zJLuL/Org7r8v3humo 8QPqgZBG3V27PygRU/vE3aUeA6c5HwTu4plTjMYXaYCH65er0VPAUq8PxSESWvci2+3E 7llg== X-Gm-Message-State: APjAAAW4sPTDHxUnbOgjymTU+5lTmErIZP5v4psDGk6EsI+mdncJEZeU TqYG23kOqgVy5ZtH5LC3Ey6/iRVjvTw= X-Google-Smtp-Source: APXvYqz60kAgfurowvZPoAG169iujNyy/3w62eLK5qWjV4XtWedPjak0StcY9kFnvJdhXoVMQknIBQ== X-Received: by 2002:a7b:c257:: with SMTP id b23mr8000367wmj.83.1553422491912; Sun, 24 Mar 2019 03:14:51 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id d11sm10251326wmb.19.2019.03.24.03.14.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 03:14:51 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v3 13/15] net: devlink: warn on setting type on unregistered port Date: Sun, 24 Mar 2019 11:14:36 +0100 Message-Id: <20190324101438.6376-14-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us> References: <20190324101438.6376-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Port needs to be registered first before the type is set. Warn and bail-out in case it is not. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- net/core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index f4dbd404688f..b771b00a52a0 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5370,6 +5370,8 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, enum devlink_port_type type, void *type_dev) { + if (WARN_ON(!devlink_port->registered)) + return; devlink_port->type = type; devlink_port->type_dev = type_dev; devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW); -- 2.17.2