From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com,
jakub.kicinski@netronome.com, f.fainelli@gmail.com,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: [patch net-next v3 04/15] bnxt: set devlink port attrs properly
Date: Sun, 24 Mar 2019 11:14:27 +0100 [thread overview]
Message-ID: <20190324101438.6376-5-jiri@resnulli.us> (raw)
In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
Set the attrs properly so delink has enough info to generate physical
port names.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index ecb328ee8f5c..ab6fd05c462b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -229,6 +229,8 @@ int bnxt_dl_register(struct bnxt *bp)
goto err_dl_unreg;
}
+ devlink_port_attrs_set(&bp->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,
+ bp->pf.port_id, false, 0);
rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id);
if (rc) {
netdev_err(bp->dev, "devlink_port_register failed");
--
2.17.2
next prev parent reply other threads:[~2019-03-24 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 10:14 [patch net-next v3 00/15] devlink: small spring cleanup Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 01/15] net: devlink: add couple of missing mutex_destroy() calls Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 02/15] bnxt: add missing net/devlink.h include Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 03/15] dsa: " Jiri Pirko
2019-03-24 10:14 ` Jiri Pirko [this message]
2019-03-24 10:14 ` [patch net-next v3 05/15] bnxt: call devlink_port_type_eth_set() before port register Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 06/15] net: devlink: don't take devlink_mutex for devlink_compat_* Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 07/15] net: devlink: don't pass return value of __devlink_port_type_set() Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 08/15] mlxsw: Move devlink_port_attrs_set() call before register Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 09/15] dsa: move " Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 10/15] net: devlink: disallow port_attrs_set() to be called " Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 11/15] nfp: move devlink port type set after netdev registration Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 12/15] bnxt: set devlink port type after registration Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 13/15] net: devlink: warn on setting type on unregistered port Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 14/15] net: devlink: add port type spinlock Jiri Pirko
2019-03-24 10:14 ` [patch net-next v3 15/15] net: devlink: select NET_DEVLINK from drivers Jiri Pirko
2019-03-24 19:04 ` [patch net-next v3 00/15] devlink: small spring cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324101438.6376-5-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).