From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: brouer@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
fw@strlen.de
Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list
Date: Sun, 24 Mar 2019 19:23:02 +0100 [thread overview]
Message-ID: <20190324192302.5503031b@carbon> (raw)
In-Reply-To: <20190324165644.21303-1-nbd@nbd.name>
On Sun, 24 Mar 2019 17:56:44 +0100
Felix Fietkau <nbd@nbd.name> wrote:
> Since we're freeing multiple skbs, we might as well use bulk free to save a
> few cycles. Use the same conditions for bulk free as in napi_consume_skb.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> v2: call kmem_cache_free_bulk once the skb array is full instead of
> falling back to kfree_skb
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-03-24 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 16:56 [PATCH v2] net: use bulk free in kfree_skb_list Felix Fietkau
2019-03-24 18:23 ` Jesper Dangaard Brouer [this message]
2019-03-25 8:51 ` Eric Dumazet
2019-03-25 9:09 ` Felix Fietkau
2019-03-25 9:31 ` Eric Dumazet
2019-03-25 9:35 ` Felix Fietkau
2019-03-25 16:03 ` Jesper Dangaard Brouer
2019-03-25 8:54 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324192302.5503031b@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).