From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1F5C43381 for ; Mon, 25 Mar 2019 06:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93BEC2075C for ; Mon, 25 Mar 2019 06:49:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="r2XlHOx9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729727AbfCYGtQ (ORCPT ); Mon, 25 Mar 2019 02:49:16 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34763 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729400AbfCYGtQ (ORCPT ); Mon, 25 Mar 2019 02:49:16 -0400 Received: by mail-wr1-f65.google.com with SMTP id p10so8724709wrq.1 for ; Sun, 24 Mar 2019 23:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+vyXMylrNIcWNN9Lh8RZlchjxjBR2dp4lkkOQyB1WnE=; b=r2XlHOx9JOkPzFVfLTXZXVBQJ0zv/vh5t7Q0aNOtFNYb+w7zmht77h+Z7pBibAZ0r9 wpbUP/RJogRxadw4+O42jR3+eQCW5LxnT+DKFqa1m01GCdTz/MWEIT7Tw4ArQzw33dUN r8YvCwQogX3fjKVp5rcwu0FUXMZdqbS8PYAOuK97vudLRNQSO2wfapbYb9of2eM4ip+5 yXj/CSB1bHirNtYi3SkCSiSo6t/7rr6O/dCPLbFI+al125TyoO1BgPb3WFzSbuBUAhQh M7ABAK7i5hCQlfmTiI0QwZ1wPWl05f/7YHuSNB3y02v/MMfPifwdNorPjiYYB8jCD1BQ Uu4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+vyXMylrNIcWNN9Lh8RZlchjxjBR2dp4lkkOQyB1WnE=; b=b2pN4ErnPxOen+kpyColrDYDnnlfFJnV1ajcIaUgp0xbte7/+27sKxdixuRupIk16p QcILw+oiGm7Urf9DnHu5Sca+0S/vS1gX58uREitOIjI50FDakyEak1v06fBhpmBFOhTQ Kf0xEzmI/RG2Lh5/rB+8v2JIol/1oH1i+8zJw/n4iyJMg46WPQe6F5umNqZeI74f3+qF w67o4CI9zLjA14jrwe+AC3oD+OvLi+kkC6D6CGLkE9sBb4qMD/MmL2YySVSXQwuVhzzv eeFJoiA+507d6GvyHHIWixmpVKzk74pt37yDqO/WHPyX8bXETduyB6YdaIR0CbMDdRmf Zd5A== X-Gm-Message-State: APjAAAVGd4Fq4yhsfT39CsFsZI4DR6HKr34SMUMm+KomsZQr05YvpD8d s6ZllX5e0aTV5tMw6FAxrCyIfzFicD0= X-Google-Smtp-Source: APXvYqxGvqTMvf21NJmpTneIy9LrFbUfDpmPe1zbekp9PdCy2lWu9C6kw8FcubWN43LieGOBc6OXlw== X-Received: by 2002:a5d:4646:: with SMTP id j6mr3941930wrs.56.1553496554209; Sun, 24 Mar 2019 23:49:14 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id o15sm14337957wrj.59.2019.03.24.23.49.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 23:49:13 -0700 (PDT) Date: Mon, 25 Mar 2019 07:38:29 +0100 From: Jiri Pirko To: Olga Albisser Cc: netdev@vger.kernel.org, Olga Albisser , Koen De Schepper , Oliver Tilmans , Bob Briscoe , Henrik Steen Subject: Re: [PATCHv2 net-next] sched: add dualpi2 scheduler module Message-ID: <20190325063829.GA8856@nanopsycho.orion> References: <20190324215253.14390-1-olga@albisser.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190324215253.14390-1-olga@albisser.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sun, Mar 24, 2019 at 10:52:53PM CET, olgabnd@gmail.com wrote: >DUALPI2 provides extremely low latency & loss to traffic that uses a >scalable congestion controller (e.g. L4S, DCTCP) without degrading the >performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is intended >to be the reference implementation of the IETF's DualQ Coupled AQM. > >The qdisc provides two queues called low latency and classic. It >classifies packets based on the ECN field in their IP headers. By default >it directs non-ECN and ECT(0) into the Classic queue and ECT(1) and CE >into the low latency queue, as per the IETF spec. > >There is an AQM in each queue. >* The Classic AQM is called PI2, which is similar to the PIE AQM but more >responsive and simpler. Classic traffic requires a decent target queue >(default 15ms for Internet deployment) to fully utilize the link. >* The low latency AQM is, by default, a simple very shallow ECN marking >threshold similar to that used for DCTCP. > >The DualQ isolates the extremely low queuing delay of the Low Latency >queue from the larger delay of the 'Classic' queue. However, from a >bandwidth perspective, flows in either queue will share out the link >capacity as if there was just a single queue. This bandwidth pooling >effect is achieved by coupling together the drop and ECN-marking >probabilities of the two AQMs. > >The PI2 AQM has two main parameters in addition to its target delay. All >the defaults are suitable for any Internet setting, but it can be >reconfigured for a Data Centre setting. The integral gain factor alpha is >used to slowly correct any persistent standing queue error from the >target delay, while the proportional gain factor beta is used to quickly >compensate for queue changes (growth or shrinkage). > >Internally, the output of a simple linear Proportional Integral (PI) >controller is used for both queues. This output is squared to calculate >the drop or ECN-marking probability of the classic queue. This >counterbalances the square-root rate equation of Reno/Cubic, which is the >trick that balances flow rates across the queues. For the ECN-marking >probability of the low latency queue, the output of the base AQM is >multiplied by a coupling parameter k . This determines the balance >between the flow rates in each queue. The default setting makes the flow >rates roughly equal, which should be generally applicable. > >If DUALPI2 AQM has detected overload (when excessive non-responsive >traffic is sent), it will switch to signalling congestion solely using >drop, irrespective of the ECN field, or alternatively it can be >configured to limit the drop probability and let the queue grow and >eventually overflow (like tail-drop). > >Additional details can be found in the draft: >https://www.ietf.org/id/draft-ietf-tsvwg-aqm-dualq-coupled > >Signed-off-by: Olga Albisser >Signed-off-by: Koen De Schepper >Signed-off-by: Oliver Tilmans >Signed-off-by: Bob Briscoe >Signed-off-by: Henrik Steen >--- For v2 and above, please provide changelog here. Thanks!