From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D4DC43381 for ; Mon, 25 Mar 2019 16:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0630B20896 for ; Mon, 25 Mar 2019 16:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbfCYQRf (ORCPT ); Mon, 25 Mar 2019 12:17:35 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40917 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729514AbfCYQRe (ORCPT ); Mon, 25 Mar 2019 12:17:34 -0400 Received: by mail-pl1-f196.google.com with SMTP id b11so176479plr.7 for ; Mon, 25 Mar 2019 09:17:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mhR59C0bZkFAZVgYiFLX1iW2ufR5rsO3ckbomej8kCA=; b=oTbcAahsF/HTTsiBHMJISe1T8yQqySwr3OG0aHPo7OGjcmpDxaKY5SO1dDvDYKHpTt pwqDh2D3xdrox99zQRo+LYbjp8Wcj5nGT4PlXf/vsYTKwK20WVReXfBMXMqXy4T2vnq+ aAN9oW1RHfIm8AvVPuzkYnTjM6Z2BkVW1Fe7Ax+748d59dDKhvy14u8uhYxnV8adCbst OkQxI4gw/hzwdmdyo9xMRKekWv+O6eTvWgLbt3lTnXQ8IvKxPQ5RWtKpJijahOpzneTP JO6SoMDennfiZxpHuKRPaeyAq2rRB6Fe0MWa64gPuRl9C2yoGkNFarI3NoAydE9Xsw8d OGfw== X-Gm-Message-State: APjAAAWpA/0IO7c4elWH1DJpq2urV8VADSP4gDz/oF2U+rrGV5mstswI GhW7HO4C+0w1fUtXgL76LdI= X-Google-Smtp-Source: APXvYqwPWl612MVfzNUgaHY00lcMSxOt1FhEg42w/IV+A8pE1nV0ssDG5h49VycgIN1FSOM3r0ugtw== X-Received: by 2002:a17:902:584:: with SMTP id f4mr26647343plf.330.1553530653408; Mon, 25 Mar 2019 09:17:33 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id 4sm8931854pgx.68.2019.03.25.09.17.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 09:17:32 -0700 (PDT) From: Bart Van Assche To: David Miller Cc: netdev@vger.kernel.org, Bart Van Assche , Al Viro Subject: [PATCH v2 2/5] net/core: Document all dev_ioctl() arguments Date: Mon, 25 Mar 2019 09:17:20 -0700 Message-Id: <20190325161723.144556-3-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190325161723.144556-1-bvanassche@acm.org> References: <20190325161723.144556-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch avoids that the following warnings are reported when building with W=1: net/core/dev_ioctl.c:378: warning: Function parameter or member 'ifr' not described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Function parameter or member 'need_copyout' not described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl' Cc: Al Viro Fixes: 44c02a2c3dc5 ("dev_ioctl(): move copyin/copyout to callers") # v4.16. Signed-off-by: Bart Van Assche --- net/core/dev_ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 31380fd5a4e2..5163d900bb4f 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -366,7 +366,8 @@ EXPORT_SYMBOL(dev_load); * dev_ioctl - network device ioctl * @net: the applicable net namespace * @cmd: command to issue - * @arg: pointer to a struct ifreq in user space + * @ifr: pointer to a struct ifreq in user space + * @need_copyout: whether or not copy_to_user() should be called * * Issue ioctl functions to devices. This is normally called by the * user space syscall interfaces but can sometimes be useful for -- 2.21.0.155.ge902e9bcae20