From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>,
netdev@vger.kernel.org, davem@davemloft.net, fw@strlen.de,
pabeni@redhat.com, brouer@redhat.com
Subject: Re: [PATCH v3] net: use bulk free in kfree_skb_list
Date: Mon, 25 Mar 2019 16:49:29 +0100 [thread overview]
Message-ID: <20190325164929.03d67fb6@carbon> (raw)
In-Reply-To: <5d973ed2-1915-a87d-d10f-6a0f68240ac0@gmail.com>
On Mon, 25 Mar 2019 02:27:14 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > +#ifdef CONFIG_SLUB
> > + /* SLUB writes into objects when freeing */
> > + prefetchw(segs);
> > +#endif
>
> This is done too late :
> You should probably either remove this prefetchw()
> or do it before reading segs->next at the beginning of the loop.
Agree. Not sure the prefetchw optimization makes sense here. IHMO just
drop it in this patch.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2019-03-25 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:14 [PATCH v3] net: use bulk free in kfree_skb_list Felix Fietkau
2019-03-25 9:27 ` Eric Dumazet
2019-03-25 15:49 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325164929.03d67fb6@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).