From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05097C43381 for ; Mon, 25 Mar 2019 18:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3F8A20685 for ; Mon, 25 Mar 2019 18:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730037AbfCYS0q (ORCPT ); Mon, 25 Mar 2019 14:26:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728912AbfCYS0q (ORCPT ); Mon, 25 Mar 2019 14:26:46 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1E6330832F4; Mon, 25 Mar 2019 18:26:45 +0000 (UTC) Received: from bistromath.localdomain (unknown [10.40.205.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 335DC26350; Mon, 25 Mar 2019 18:26:43 +0000 (UTC) Date: Mon, 25 Mar 2019 19:26:42 +0100 From: Sabrina Dubroca To: Bart Van Assche Cc: David Miller , netdev@vger.kernel.org, Willem de Bruijn Subject: Re: [PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency Message-ID: <20190325182642.GA14636@bistromath.localdomain> References: <20190325161723.144556-1-bvanassche@acm.org> <20190325161723.144556-6-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190325161723.144556-6-bvanassche@acm.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 25 Mar 2019 18:26:45 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-03-25, 09:17:23 -0700, Bart Van Assche wrote: > diff --git a/net/core/datagram.h b/net/core/datagram.h > new file mode 100644 > index 000000000000..bcfb75bfa3b2 > --- /dev/null > +++ b/net/core/datagram.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _NET_CORE_DATAGRAM_H_ > +#define _NET_CORE_DATAGRAM_H_ > + > +#include > + > +struct sock; > +struct sk_buff; > +struct iov_iter; > + > +int __zerocopy_sg_from_iter(struct sock *sk, struct sk_buff *skb, > + struct iov_iter *from, size_t length); > + > +#endif /* _NET_CORE_DATAGRAM_H_ */ That's rather ugly. Could it just be moved to an appropriate file in include/? -- Sabrina