From: David Miller <davem@davemloft.net>
To: ioana.ciornei@nxp.com
Cc: netdev@vger.kernel.org, ruxandra.radulescu@nxp.com
Subject: Re: [PATCH net] dpaa2-eth: fix race condition with bql frame accounting
Date: Tue, 26 Mar 2019 11:44:49 -0700 (PDT) [thread overview]
Message-ID: <20190326.114449.1831544566357747372.davem@davemloft.net> (raw)
In-Reply-To: <1553519146-31375-1-git-send-email-ioana.ciornei@nxp.com>
From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: Mon, 25 Mar 2019 13:06:22 +0000
> It might happen that Tx conf acknowledges a frame before it was
> subscribed in bql, as subscribing was previously done after the enqueue
> operation.
>
> This patch moves the netdev_tx_sent_queue call before the actual frame
> enqueue, so that this can never happen.
>
> Fixes: 569dac6 ("dpaa2-eth: bql support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Please always use 12 digits of signifigance for SHA1 values in Fixes: tags
as per the patch submission guidelines.
I fixed it up for you this time.
Applied, thanks.
prev parent reply other threads:[~2019-03-26 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:06 [PATCH net] dpaa2-eth: fix race condition with bql frame accounting Ioana Ciornei
2019-03-26 18:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326.114449.1831544566357747372.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).