From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2466FC43381 for ; Tue, 26 Mar 2019 18:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2C71206DF for ; Tue, 26 Mar 2019 18:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732617AbfCZSov (ORCPT ); Tue, 26 Mar 2019 14:44:51 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48672 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732424AbfCZSou (ORCPT ); Tue, 26 Mar 2019 14:44:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3254814C5F2C1; Tue, 26 Mar 2019 11:44:50 -0700 (PDT) Date: Tue, 26 Mar 2019 11:44:49 -0700 (PDT) Message-Id: <20190326.114449.1831544566357747372.davem@davemloft.net> To: ioana.ciornei@nxp.com Cc: netdev@vger.kernel.org, ruxandra.radulescu@nxp.com Subject: Re: [PATCH net] dpaa2-eth: fix race condition with bql frame accounting From: David Miller In-Reply-To: <1553519146-31375-1-git-send-email-ioana.ciornei@nxp.com> References: <1553519146-31375-1-git-send-email-ioana.ciornei@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Mar 2019 11:44:50 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ioana Ciornei Date: Mon, 25 Mar 2019 13:06:22 +0000 > It might happen that Tx conf acknowledges a frame before it was > subscribed in bql, as subscribing was previously done after the enqueue > operation. > > This patch moves the netdev_tx_sent_queue call before the actual frame > enqueue, so that this can never happen. > > Fixes: 569dac6 ("dpaa2-eth: bql support") > Signed-off-by: Ioana Ciornei Please always use 12 digits of signifigance for SHA1 values in Fixes: tags as per the patch submission guidelines. I fixed it up for you this time. Applied, thanks.