From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C89C43381 for ; Tue, 26 Mar 2019 03:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BC582075C for ; Tue, 26 Mar 2019 03:05:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTYn/sPT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730377AbfCZDFm (ORCPT ); Mon, 25 Mar 2019 23:05:42 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34400 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbfCZDFm (ORCPT ); Mon, 25 Mar 2019 23:05:42 -0400 Received: by mail-pf1-f194.google.com with SMTP id b3so6015533pfd.1 for ; Mon, 25 Mar 2019 20:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=X7nFaJGSsxjJqhGwgGEevqXR5qXH9PJUTOP3kiM00hs=; b=HTYn/sPTWyGMT5N6ummsJyepw0GELeDIgsXFsBmTWKribS2PgMssWoIurDeHureaqb accNRPV1LQjw14LaMac8EIMfCpOfXofoOozmjwOfZYcDAtg2IiztMpUGuOvrfjEEmJmu nJ8V56WWFZchho4ZMasA9x9jxOHQ3zrVcZTHPwIELSAF1z4lMMSoz+yZsp3OiNfe6Muz 1xCgIk7WifIAY8kBgwKSmZnLUEl4k8hCAla4JhOnSFflXcg+RpF3mLdi0tVyUm5FIiYT 7VQCibCBRalz4dv4Cpmnvc8f7rdEmP1Rtk9jPru8cQXYcqScVpnPWSqSZ4yxZaIwfJTZ GXAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=X7nFaJGSsxjJqhGwgGEevqXR5qXH9PJUTOP3kiM00hs=; b=N4w+1JUFBWg5vJTlw7QhXRNc2k0Kn9nW+VWgEGxx/gGmrDb7jo6OOtU2tXTrip1GCm 5bMenfgbsD91xwwfh81udZcVY0xEHBIl9QREH36LJnQrWUr/u2eFaMViLpBv4Sh8xnUk DC9LtjmmHWJijiDjw11cTzE9HfvsH5J3T0LN6Ab1lvDAxPRVoqkWnCTEpisRAYw65cPS UTmOje8KH8AQeI8FpHI3/NyXfxEyYsKVQ1JpZ4vNsYqxYH8JcaomKFXnQUe+aizTjlu+ LaNmPLYXSoTVK+E2U3x1j03jRJF5A1g7fOeb1QijQuP7ViQiAahYQMMBSFIN33B6/JdG 7B6Q== X-Gm-Message-State: APjAAAX5A8gkgdq+oZYWAsHCHja//GiiCte4SeS8D0Wd09a99/OxGuU9 rVXHQtQoqYQPkIgVJkbZlKk= X-Google-Smtp-Source: APXvYqzV7Y3PMHW2aNv92nfc4AKzMDu+AqxBxV5AL/w+JvzGqOSvviw/xEiuHp5GTEwBJRMAChiFjA== X-Received: by 2002:a65:448b:: with SMTP id l11mr3112556pgq.185.1553569541420; Mon, 25 Mar 2019 20:05:41 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:180::b29f]) by smtp.gmail.com with ESMTPSA id r82sm31118837pfa.161.2019.03.25.20.05.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 20:05:40 -0700 (PDT) Date: Mon, 25 Mar 2019 20:05:39 -0700 From: Alexei Starovoitov To: David Ahern Cc: David Miller , netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file Message-ID: <20190326030536.kjzp2redp33y7hk6@ast-mbp> References: <20190322130609.11655-1-dsahern@kernel.org> <20190323.214023.610983922857554034.davem@davemloft.net> <20190324035550.b4qjyl5ccfvc3tzi@ast-mbp> <20190325032641.5xyav65phoeadgye@ast-mbp> <61520dad-939f-46ff-626b-dea91b845aa3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <61520dad-939f-46ff-626b-dea91b845aa3@gmail.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 25, 2019 at 11:02:07AM -0600, David Ahern wrote: > > That is followed by refactoring IPv6 again in a direction that makes > IPv4 and IPv6 more consistent and enables changes (outside of the > nexthop sets) that will improve IPv6 for a number of cases by removing > the need to always generate a dst_entry. That would be a nice feature to have. > After that are a few patches exporting functions for use by nexthop code > and then diving into the refactoring enabling separate nexthop objects. > Again, impacts to performance have been top of mind, and I have done > what I can to minimize any overhead in the datapath - to the point of a > few ‘if (nh)’ checks wrapped in an unlikely. And with the nexthop code > in place it gives users an alternative to a broken IPv6 multipath API as > one example. ... > Again, I have tried to be very careful with the intrusion of checks into > the datapath with the goal of no measurable impact to performance. I am > invested to seeing that through and will continue looking for ways to > improve it for all use cases. Great to hear. Can you split up your set into reviewable chunks? Just this patch alone is too small to see the road ahead and 80+ patches are too much to review properly. I still have reservations regarding nexthop id concept, but sounds like the first 20 or so patches should clean things up. Especially if you can get rid of dst alloc/free back and forth in ipv6 case.