From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 362D9C43381 for ; Tue, 26 Mar 2019 20:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04CDA20823 for ; Tue, 26 Mar 2019 20:27:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="RLsFK+9b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732585AbfCZU1n (ORCPT ); Tue, 26 Mar 2019 16:27:43 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40441 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732119AbfCZU1m (ORCPT ); Tue, 26 Mar 2019 16:27:42 -0400 Received: by mail-pg1-f196.google.com with SMTP id u9so8779799pgo.7 for ; Tue, 26 Mar 2019 13:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=nEr21S4pEbIRVkmpkKIR5DZUnSfBJ2rS5dyEV/jl83A=; b=RLsFK+9bkESjOe5C3E78il16FoL7gTfMyeA7xwirrO0hqvujRow+DnHQWNpb3jj+2U Kg1SsEJNTWx6RuGvVy0K+eUtWPLoVkoLr5emVbywWpnWh3OxNp4d19ZHmp84omGbsD79 KRe+qQw2bouxOlEI0CZY9oI71biN/DVXRASChW67lBybGpcIwtshE9GnJ7cmIy3VqOoF GnNBxMIeKooYn0qHVuHtY774BhoMbQOhegOauK8sOpBEz9yR0a/SQnDH6Ue15m/2peP3 86Edu1YJL/NzQpkht81sqAunnixBLTbBilKQM3a+1VeBe8H9jYQ0HK0ADG8rw5OvE8nH gyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=nEr21S4pEbIRVkmpkKIR5DZUnSfBJ2rS5dyEV/jl83A=; b=WHL03ARJsJpKUeE3JkSTFNBPLUHh9ZSJwa8ECw45XNteFYHD5fZ+BihGfhcXKI7RiX IT/6Q17+XmEBqUcQXNQ1K5xGz8p0uNGgCeN6LLE0e1uS4esCHFpCX5TY+MZEbyyWRnwb PT1l/OLkKCHiFV/mjKqPd2HxX+ftNERWskK9wfH6bCMGXbQ7KRvsRrQNDaZUZbo5+pec TTPaUYIN9Mzjcujnq6PC5UljcxQbcN4BU6jcwmNb6oV3KsmPTZTf/uvbPZLMCUxq1sHi MMEId5kXgRE+CDxr80cAnKlnlvJpAp48ffd3nXs+qWsNjkrz0zkmAbwI8vnv5Q7eMwQr 7yaA== X-Gm-Message-State: APjAAAWH4gdQZQuQZmfN0WcrKerPCeJQ9K4/48SBPfIsWzuZq3fqedTv se/E4k4mKTtLd70VMU5QY2TI2Q== X-Google-Smtp-Source: APXvYqy07N2JkE4MU66yCAFl+bzlXY9bjlSYN5Lk187DStobe3oq9hK4WGxnP2OF2udT7NUCWgVDIQ== X-Received: by 2002:a63:1048:: with SMTP id 8mr7555598pgq.70.1553632062099; Tue, 26 Mar 2019 13:27:42 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id i64sm29234473pfb.112.2019.03.26.13.27.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 13:27:41 -0700 (PDT) Date: Tue, 26 Mar 2019 13:27:37 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next v2 01/12] net: replace ndo_get_devlink with ndo_get_devlink_port Message-ID: <20190326132737.390e7225@cakuba.netronome.com> In-Reply-To: <20190326120307.2953-2-jiri@resnulli.us> References: <20190326120307.2953-1-jiri@resnulli.us> <20190326120307.2953-2-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 26 Mar 2019 13:02:56 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Follow-up patch is going to need a devlink port instance according to > a netdev. Devlink port instance should be always available when devlink > is used. So change the recently introduced ndo_get_devlink to > ndo_get_devlink_port. With that, adjust the wrapper for the only > user to get devlink pointer. > > Signed-off-by: Jiri Pirko > Reviewed-by: Michal Kubecek > Reviewed-by: Florian Fainelli Makes sense, but you gotta fix up the nfp to register devlink ports first, like I did in: https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git/commit/?h=devlink-pci-ports&id=1debfdef5aef369412e72f370d11120d309a6a74 please.