From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E60B9C4360F for ; Tue, 26 Mar 2019 14:43:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C03F620823 for ; Tue, 26 Mar 2019 14:43:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731988AbfCZOnd (ORCPT ); Tue, 26 Mar 2019 10:43:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58784 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731943AbfCZOnV (ORCPT ); Tue, 26 Mar 2019 10:43:21 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FA6E356F1; Tue, 26 Mar 2019 14:43:21 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id B24FD17A64; Tue, 26 Mar 2019 14:43:16 +0000 (UTC) Date: Tue, 26 Mar 2019 15:43:15 +0100 From: Jesper Dangaard Brouer To: Ioana Ciornei Cc: brouer@redhat.com, "davem@davemloft.net" , "netdev@vger.kernel.org" , Ioana Ciocoi Radulescu , Florian Westphal , Edward Cree Subject: Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list Message-ID: <20190326154315.7476de9d@carbon> In-Reply-To: <1553521344-31094-1-git-send-email-ioana.ciornei@nxp.com> References: <1553521344-31094-1-git-send-email-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 26 Mar 2019 14:43:21 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 25 Mar 2019 13:42:39 +0000 Ioana Ciornei wrote: > Take advantage of the software Rx batching by using > netif_receive_skb_list instead of napi_gro_receive. > > Signed-off-by: Ioana Ciornei > --- Nice to see more people/drivers using: netif_receive_skb_list() We should likely add a similar napi_gro_receive_list() function. > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 +++++++- > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > index 2ba49e9..e923e5c 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > @@ -435,7 +435,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv, > percpu_stats->rx_packets++; > percpu_stats->rx_bytes += dpaa2_fd_get_len(fd); > > - napi_gro_receive(&ch->napi, skb); > + list_add_tail(&skb->list, ch->rx_list); > > return; > > @@ -1108,12 +1108,16 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget) > struct dpaa2_eth_fq *fq, *txc_fq = NULL; > struct netdev_queue *nq; > int store_cleaned, work_done; > + struct list_head rx_list; > int err; > > ch = container_of(napi, struct dpaa2_eth_channel, napi); > ch->xdp.res = 0; > priv = ch->priv; > > + INIT_LIST_HEAD(&rx_list); > + ch->rx_list = &rx_list; > + > do { > err = pull_channel(ch); > if (unlikely(err)) > @@ -1157,6 +1161,8 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int budget) > work_done = max(rx_cleaned, 1); > > out: > + netif_receive_skb_list(ch->rx_list); > + > if (txc_fq && txc_fq->dq_frames) { > nq = netdev_get_tx_queue(priv->net_dev, txc_fq->flowid); > netdev_tx_completed_queue(nq, txc_fq->dq_frames, > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > index 7879622..a11ebfd 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > @@ -334,6 +334,7 @@ struct dpaa2_eth_channel { > struct dpaa2_eth_ch_stats stats; > struct dpaa2_eth_ch_xdp xdp; > struct xdp_rxq_info xdp_rxq; > + struct list_head *rx_list; > }; > > struct dpaa2_eth_dist_fields { -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer