From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61764C43381 for ; Tue, 26 Mar 2019 16:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A5432070D for ; Tue, 26 Mar 2019 16:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732099AbfCZQSv convert rfc822-to-8bit (ORCPT ); Tue, 26 Mar 2019 12:18:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731613AbfCZQSv (ORCPT ); Tue, 26 Mar 2019 12:18:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6326430BC65D; Tue, 26 Mar 2019 16:18:51 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D9456B80E; Tue, 26 Mar 2019 16:18:45 +0000 (UTC) Date: Tue, 26 Mar 2019 17:18:44 +0100 From: Jesper Dangaard Brouer To: Dean Nelson Cc: brouer@redhat.com, Robert Richter , Sunil Goutham , David Miller , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vadim Lomovtsev Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling Message-ID: <20190326171844.014b1918@carbon> In-Reply-To: <08849eac-c185-ee0d-3907-85beb392899b@redhat.com> References: <155361559092.14454.4615730926574762068.email-sent-by-dnelson@cyan> <08849eac-c185-ee0d-3907-85beb392899b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 26 Mar 2019 16:18:51 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 26 Mar 2019 11:09:10 -0500 Dean Nelson wrote: > On 3/26/19 10:53 AM, Dean Nelson wrote: > > In attempting to optimize receive buffer page recycling for XDP, commit > > 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP") > > inadvertently introduced two problems for the non-XDP case, that will be > > addressed by this patch series. > > > > Dean Nelson (2): > > thunderx: enable page recycling for non-XDP case > > thunderx: eliminate extra calls to put_page() for pages held for recycling > > > > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++---------------- > > 1 file changed, 14 insertions(+), 16 deletions(-) > > > > > I'm really sorry, I completely forgot to add a description > of what the changes were made by v2 (which was just to add > the 'Fixes:' lines to the changelogs). That should be okay, for such a small change. > And I forgot to add you to the CC-list. I'm assuming I > should repost? Right? (And do you want to be added?) > > It's just one of those days. I can live with not getting Cc'ed (but I would prefer it), but some other adjustments. There should not be a newline between "Fixes:" and "Signed-off-by:". And nitpicking, I believe that we usually only show the first 12 chars of the commit id. I have setup git to use: 'git show --pretty=fixes' >From my ~/.gitconfig: --------------------- [core] abbrev = 12 [pretty] fixes = Fixes: %h (\"%s\") -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer