From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, alexander.duyck@gmail.com,
christoph.paasch@gmail.com
Subject: Re: [PATCH net] net: datagram: fix unbounded loop in __skb_try_recv_datagram()
Date: Wed, 27 Mar 2019 21:59:53 -0700 (PDT) [thread overview]
Message-ID: <20190327.215953.1992775219057881382.davem@davemloft.net> (raw)
In-Reply-To: <e74e52876fa38b9585805786571d9dd2ad1e69a3.1553519202.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Mon, 25 Mar 2019 14:18:06 +0100
> Christoph reported a stall while peeking datagram with an offset when
> busy polling is enabled. __skb_try_recv_datagram() uses as the loop
> termination condition 'queue empty'. When peeking, the socket
> queue can be not empty, even when no additional packets are received.
>
> Address the issue explicitly checking for receive queue changes,
> as currently done by __skb_wait_for_more_packets().
>
> Fixes: 2b5cd0dfa384 ("net: Change return type of sk_busy_loop from bool to void")
> Reported-and-tested-by: Christoph Paasch <cpaasch@apple.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied and queued up for -stable, thanks Paolo.
prev parent reply other threads:[~2019-03-28 4:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:18 [PATCH net] net: datagram: fix unbounded loop in __skb_try_recv_datagram() Paolo Abeni
2019-03-28 4:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327.215953.1992775219057881382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=christoph.paasch@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).