From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E067CC43381 for ; Wed, 27 Mar 2019 03:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF2472082F for ; Wed, 27 Mar 2019 03:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pjCPpnCh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732629AbfC0Duh (ORCPT ); Tue, 26 Mar 2019 23:50:37 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41243 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbfC0Duh (ORCPT ); Tue, 26 Mar 2019 23:50:37 -0400 Received: by mail-pg1-f196.google.com with SMTP id f6so5143329pgs.8 for ; Tue, 26 Mar 2019 20:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HrkdE4ZPMakoQGw1NikifglHngnhj9YYeZwR9ymizXw=; b=pjCPpnChHvg6ivnLynk6YzW9E8/bVYJ0rC8RzAGOAne02YXnnYqF70zknnTHXK/EK2 594sY+B4rvP5v/a85rA43UGeoEa0HZ1sqSUU1HkOM6adl8RVsAY/RiD5ixdb67HYEDGv oy9EjF+8jvGjV11bWSkLxCs2A+C+BbKQoGo9DtJ4Zt3jWdwBj0FolLKpvFaCiu5WM+yS o6FksMnHXZZTu1wQykDitSofqfBk98H/xy3LBznMzCsElVjuW6oEsZcbDF0srIPEQWnU OLd2lqk796AGmkBVWHsFk5k+u/efcp79dW9j+EcbCG/yM1ca+uiTncoLvxSJs/c4uGcn mIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HrkdE4ZPMakoQGw1NikifglHngnhj9YYeZwR9ymizXw=; b=P9YnKWVjbr/lj8KaFj6aalOjObFqzXXQfd6my8paEWroD/BcKJVdR413fiZ2FcfrO6 JN5l69UL8gnj/BcCsBA4/D9Jv5lycLB+U7j9DKciTXkHKiOYrWS6DJf0wLjsp6HGo8o2 iJcTcfaCbl7jg22eTJ/fBMPIE2eDtUXtFncjs/EYRrR+tQeOm8/SHZvkpKV2OwR5uK4H /vs9ed5X6CLBEVdcK6A55G2KpS1A/lqEabAH6/zYNuL0L3Ba9EbQ4Ts+PlQ+FrPiYojJ 8oQ/BuWK85F6Uw2KLf0TOTp8fSddFc+Vaw5aTJL1H7fByN8tzdOmJ1MjF7wpN5K9f62G eZ+Q== X-Gm-Message-State: APjAAAVa0lvEPn9abYkpxeuxE8heUOKA3ujpAlfIVY5JrcE4PIQz6Zf5 0P8WhUG92JpG5Av1I+8xIyehGQ== X-Google-Smtp-Source: APXvYqzSbwiEB0m5geqV4YMX167VmPH1OM9jvi5bkqm5ih3ltaIGq4BRESozymM+xMzKhd3wQTDt5Q== X-Received: by 2002:a62:445a:: with SMTP id r87mr32542333pfa.13.1553658636093; Tue, 26 Mar 2019 20:50:36 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id k83sm68864495pfj.178.2019.03.26.20.50.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 20:50:35 -0700 (PDT) Date: Tue, 26 Mar 2019 20:50:33 -0700 From: Bjorn Andersson To: xiaofeis Cc: davem@davemloft.net, vkoul@kernel.org, netdev@vger.kernel.org, andrew@lunn.ch, linux-arm-msm@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, niklas.cassel@linaro.org, xiazha@codeaurora.org Subject: Re: [PATCH] net: dsa: Implement flow_dissect callback for tag_qca Message-ID: <20190327035033.GC1651@tuxbook-pro> References: <1553650359-15959-1-git-send-email-xiaofeis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1553650359-15959-1-git-send-email-xiaofeis@codeaurora.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue 26 Mar 18:32 PDT 2019, xiaofeis wrote: > Add flow_dissect for qca tagged packet to get the right hash. > > Signed-off-by: xiaofeis Hi Xiaofei, Please use your full name (first and last) both as author and in the signed-off tag. Regards, Bjorn > --- > net/dsa/tag_qca.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c > index e886a3c..f4b4de3 100644 > --- a/net/dsa/tag_qca.c > +++ b/net/dsa/tag_qca.c > @@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff *skb, struct net_device *dev, > return skb; > } > > +static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto, > + int *offset) > +{ > + *offset = QCA_HDR_LEN; > + *proto = ((__be16 *)skb->data)[0]; > + > + return 0; > +} > + > const struct dsa_device_ops qca_netdev_ops = { > .xmit = qca_tag_xmit, > .rcv = qca_tag_rcv, > + .flow_dissect = qca_tag_flow_dissect, > .overhead = QCA_HDR_LEN, > }; > -- > 1.9.1 >