From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFFDC43381 for ; Wed, 27 Mar 2019 07:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2AEB2075D for ; Wed, 27 Mar 2019 07:40:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="p2YN2k6r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732057AbfC0HkW (ORCPT ); Wed, 27 Mar 2019 03:40:22 -0400 Received: from mail-eopbgr50063.outbound.protection.outlook.com ([40.107.5.63]:36238 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725829AbfC0HkW (ORCPT ); Wed, 27 Mar 2019 03:40:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlf5COJT3sCtdUr4VviWRiGNiCulj34PurZ+ecxK6Us=; b=p2YN2k6r+2xAMexY2d0MiPLsJn4zaR8uZ+1Fl2nxKuf1xG4mSJIs9CwsGlrFAJnO+R+TQTH60WSA8GDLhC2fUPoqHXuDkfvXbpnbc2L/TlF0XtBAYlVvhKUlzinOOlLu3uzc+5GhF+S0GDFHSO8O9PboqLh6rCmAcJDBko8/bJ0= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB5860.eurprd05.prod.outlook.com (20.178.117.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Wed, 27 Mar 2019 07:40:17 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 07:40:17 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH net-next 01/13] ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled Thread-Topic: [PATCH net-next 01/13] ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled Thread-Index: AQHU5E1aBy3Htq5If02wJzVjbYUuTKYfGAeA Date: Wed, 27 Mar 2019 07:40:17 +0000 Message-ID: <20190327074015.GA12504@splinter> References: <20190327032942.20473-1-dsahern@kernel.org> <20190327032942.20473-2-dsahern@kernel.org> In-Reply-To: <20190327032942.20473-2-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR07CA0023.eurprd07.prod.outlook.com (2603:10a6:209:2a::36) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 381904d1-2457-4ec1-eec7-08d6b2877519 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB5860; x-ms-traffictypediagnostic: AM0PR05MB5860: x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(346002)(39850400004)(136003)(366004)(376002)(396003)(189003)(199004)(256004)(5660300002)(66066001)(486006)(478600001)(86362001)(316002)(102836004)(6436002)(8936002)(97736004)(4744005)(1076003)(54906003)(4326008)(71190400001)(105586002)(6916009)(11346002)(9686003)(446003)(81166006)(68736007)(8676002)(71200400001)(106356001)(6512007)(33716001)(2906002)(26005)(33656002)(6246003)(229853002)(52116002)(14454004)(476003)(3846002)(6506007)(6486002)(53936002)(99286004)(386003)(305945005)(186003)(6116002)(25786009)(76176011)(7736002)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB5860;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: guotF413iV8SP/FNYxfGRohFEco3IihRYjJwrGCA9W3rQhFRMrd3WmQqtsXELOdS+Zebbf+i7WL96XhQtJ6a5jwtEHI3uvLJbxX3AjL63k7pY3L/EsVt7Q+ywlyzKCH9E0TJVptaevlfBkhVVkKDVbbuMigoAyNTlE8kPj52EVJEOEt/jAo1yFGhQSlZZGPXt1fcs9e4WsriBF5AWBDqqadqmyN49L//1uMO370zSPO08KukOVLeFIoNrAkoiZR0baDKUKwNYnvO4CVJw1nBba8TP+V9cyCv1T0qh2Y3/H/RSDQ921TL23G+ya7Dyr8sFwHvfINTnSBh/vzArKYm/ik+cfCzS5PUUasDJVvdl5794QcKUjoBJJdBT1eWTMF+6AFLHY/KfSj6nL+pwxzNVj/+2yAOWslNwyGnvxSUNic= Content-Type: text/plain; charset="us-ascii" Content-ID: <58C87575563D0A4687C8EEF1FB692219@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 381904d1-2457-4ec1-eec7-08d6b2877519 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 07:40:17.8209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5860 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 26, 2019 at 08:29:30PM -0700, David Ahern wrote: > From: David Ahern >=20 > Define fib_get_nhs to return EINVAL when CONFIG_IP_ROUTE_MULTIPATH is > not enabled and remove the ifdef check for CONFIG_IP_ROUTE_MULTIPATH > in fib_create_info. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel