From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E5C0C43381 for ; Wed, 27 Mar 2019 07:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AC0520811 for ; Wed, 27 Mar 2019 07:47:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="t2NU1eXr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729662AbfC0Hrl (ORCPT ); Wed, 27 Mar 2019 03:47:41 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34680 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbfC0Hrk (ORCPT ); Wed, 27 Mar 2019 03:47:40 -0400 Received: by mail-wr1-f65.google.com with SMTP id p10so17320105wrq.1 for ; Wed, 27 Mar 2019 00:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aB5p/GBRlu1Tqfil6B9a9eN7sKtQ5BhyUqSgB7RKoOs=; b=t2NU1eXrgNlebt1Rfwe5YKdPUdW4ZHFVebwGsDUqN5c2da5CL1ytD2D8tDqWSUDAeR ZV5E3JY9pBfjFfiwRWv6DgzSvGwUpH/ZAf+OFUjsufm1+UCUe12gEzpq4ldaD1LOI709 +3uBD2ji5iV1nMC1t0UQUGlJ9Y/3QMQ84yh6gGQwSWQk5HDjsDhH2zoU0cnb7Bh3MKLL 4sUwJ7IEW+vsduDHCn9E0M13csKXSKY4yBYO0s7ikamP5uTlBNMuS9HTnh64WXH7hVDY 2x4wk4dNk/1BDrpRVhp545m1Bh6zH7qbkiXJo0fa9JW5Ix/utDtgYjHpIZaVlfDrvwys tXSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aB5p/GBRlu1Tqfil6B9a9eN7sKtQ5BhyUqSgB7RKoOs=; b=Kf7XHvirEplkJvr/O+3spwrihHrRlvMkV8X1/2lTC5/tyzGhXfE5QeftjfqduNw2Un i6tnQ2cmUXr2jihjOu1nAsTk9Jerr+PHRd40xydfWLhvy65Qw6xgKOKN/pDrrYsaTF79 EavnpDrdcjwQHSubPEgPr8yfTBVw2Nm2Jy5Y4Kuxfjr4UBisprm3rPBkf96tySXhLC5Y gdq/MkM9VfXzLe3LF7TuGBRJL2J+FxnmH3z3O7Ml+G0tNC6a+pkGDOFekPjkggVrG1FZ GCBnIJirNiGa12z12xRv6zy97QQSeeJKcjxmGZHVWvaTelAd6wN9UPXSIazncy1OY81A rGmA== X-Gm-Message-State: APjAAAW8b3C1gzw7ZtLYd44xMY/jH9vCF04iMqDaC7NE2ybwATUZBSj2 Lyyv9n80aLGlSefbeaYTIrxBJA== X-Google-Smtp-Source: APXvYqzVhOnwLxMeKxptOb6ePEbsO+dbdZEEWXooQkKIYLj2nXAWTU8EBNr0O0wT9/vbu8+YkXdinA== X-Received: by 2002:a5d:538d:: with SMTP id d13mr23172866wrv.45.1553672859279; Wed, 27 Mar 2019 00:47:39 -0700 (PDT) Received: from localhost (ip-94-113-223-73.net.upcbroadband.cz. [94.113.223.73]) by smtp.gmail.com with ESMTPSA id 66sm4609218wmd.3.2019.03.27.00.47.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 00:47:38 -0700 (PDT) Date: Wed, 27 Mar 2019 08:47:38 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next v2 01/12] net: replace ndo_get_devlink with ndo_get_devlink_port Message-ID: <20190327074738.GB3111@nanopsycho> References: <20190326120307.2953-1-jiri@resnulli.us> <20190326120307.2953-2-jiri@resnulli.us> <20190326132737.390e7225@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326132737.390e7225@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Mar 26, 2019 at 09:27:37PM CET, jakub.kicinski@netronome.com wrote: >On Tue, 26 Mar 2019 13:02:56 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Follow-up patch is going to need a devlink port instance according to >> a netdev. Devlink port instance should be always available when devlink >> is used. So change the recently introduced ndo_get_devlink to >> ndo_get_devlink_port. With that, adjust the wrapper for the only >> user to get devlink pointer. >> >> Signed-off-by: Jiri Pirko >> Reviewed-by: Michal Kubecek >> Reviewed-by: Florian Fainelli > >Makes sense, but you gotta fix up the nfp to register devlink ports >first, like I did in: > >https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git/commit/?h=devlink-pci-ports&id=1debfdef5aef369412e72f370d11120d309a6a74 > >please. I have it in next patchset: https://github.com/jpirko/linux_mlxsw/commit/d1ea97ec57762f1950d26842191070b4498044c6 Will put it here.