From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08742C43381 for ; Wed, 27 Mar 2019 14:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB5062087C for ; Wed, 27 Mar 2019 14:54:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="Th6EdOOU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728530AbfC0OyF (ORCPT ); Wed, 27 Mar 2019 10:54:05 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39167 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728066AbfC0OyF (ORCPT ); Wed, 27 Mar 2019 10:54:05 -0400 Received: by mail-pg1-f195.google.com with SMTP id k3so6355847pga.6 for ; Wed, 27 Mar 2019 07:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mxa45rf5hFG0lIGbvIfjgdr5ulX1EyPX6SRgHtNRSbU=; b=Th6EdOOUctqKMjkToAEzUVxjzC0nsJQmPlEnTlOO2ITb2JWSdRPMowSnd9Q/OzC/Yp 1EjW58Th/hkZb+rBkgNtTGyxj3l47gfBuVjGlFWnzsbATolj6L8dCc8Z21OQfEEvk3jq ASfhDFQVMRXtQD/STe0DsHSohx3xYpNLwY4GAxMueOwlfpua+DjmIovnZ8ckt+RFSD8z q4DxXTCkYB9ATbU86prlmm4+vU5lkybTpyrOU9V4CJVFhSxwd7Qbdya2YC8dq4/2jSWN crEes/Z8ll/xg02x0pjsn+06nQKqrPLbt8Ln0hEhDRTR40doDt+AtyuSnuOrJTdqEhDJ iUoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mxa45rf5hFG0lIGbvIfjgdr5ulX1EyPX6SRgHtNRSbU=; b=d+gJOxZM4uaEQbPyvGPIbYHgdmz83XPWgsCv+hiJ+ORlMizacF2bfwGz+PvsatHb6G +oCdc97XNnA/Zibx3IVyyUse/GeXAWgCF7mQRpEfez6nJ23d/elK/8OhoBCaXaqB7jF4 r/suav+Phk+kjThN1zsqnF1FwSZYWhA7D9vs9B9tQzxua3haQ0HbgpSMzwYw3b4Ndmef QpqsEVVD8HGZnxl3/uGZV4E9/N/fbdfxWIUTE4XEoD8uizo+3T8/bTIU3PFjUeocyM4r qq6t5FmWCOj9xkIBnirYM3wXMKWatjqFBGAww0ySLXKksHzIYia+xr9VjXSNM07iFueI Z8WQ== X-Gm-Message-State: APjAAAWIqGV9+cqYs8BLpiTYHKkt7oVxqjo9nC7CR7TJ60BsXl1yNWgz +UwR3CiHscBe/s+GgwgCn/ZZXDNFpH26WA== X-Google-Smtp-Source: APXvYqy9ZWebghg5xRkiucLX2Ms6ss/Z/Nf73igQLptLymIDkG9vjHVwuKm4xhaNOf1tBcywu5HLIg== X-Received: by 2002:a63:ed4f:: with SMTP id m15mr12929434pgk.387.1553698444498; Wed, 27 Mar 2019 07:54:04 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z20sm578158pgf.70.2019.03.27.07.54.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 07:54:04 -0700 (PDT) Date: Wed, 27 Mar 2019 07:53:57 -0700 From: Stephen Hemminger To: Leslie Monis Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob Message-ID: <20190327075357.293922b3@shemminger-XPS-13-9360> In-Reply-To: <20190323184835.20456-2-lesliemonis@gmail.com> References: <20190323184835.20456-1-lesliemonis@gmail.com> <20190323184835.20456-2-lesliemonis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 24 Mar 2019 00:18:34 +0530 Leslie Monis wrote: > tc_pie_xstats->prob has a maximum value of (2^64 - 1). > > Signed-off-by: Leslie Monis > --- > tc/q_pie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tc/q_pie.c b/tc/q_pie.c > index f7924ef5..6566ca10 100644 > --- a/tc/q_pie.c > +++ b/tc/q_pie.c > @@ -198,7 +198,7 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f, > st = RTA_DATA(xstats); > /*prob is returned as a fracion of maximum integer value */ > fprintf(f, "prob %f delay %uus avg_dq_rate %u\n", > - (double)st->prob / (double)0xffffffff, st->delay, > + (double)st->prob / (double)0xffffffffffffffff, st->delay, This won't work correctly on 32bit systems because that value won't fit there.. You would be better off using UINT64_MAX