From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D05EC43381 for ; Wed, 27 Mar 2019 08:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B4142075D for ; Wed, 27 Mar 2019 08:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="dhv6Ky0N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbfC0IRa (ORCPT ); Wed, 27 Mar 2019 04:17:30 -0400 Received: from mail-eopbgr30063.outbound.protection.outlook.com ([40.107.3.63]:46306 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726241AbfC0IRa (ORCPT ); Wed, 27 Mar 2019 04:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cZ99Qea+WkoouvC7UjmEUjzGSXJXAT6mwxr3byMLNcI=; b=dhv6Ky0NHFfbbdc7one/SlBfnvmqC5ocTLB0lvzk1EYL+pMT8JS3B8S+vtrPQ6AV7BbdQ0iOh3CZo4yn9AzEimZxjdTKXujHcQSEhggBL4hUXdQxGgBX6oC/0mBjqUWQYDYo9Ge680jpRjYQvVKHH5s7Eswp08u59V8ORzePBzo= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB4337.eurprd05.prod.outlook.com (52.134.93.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.17; Wed, 27 Mar 2019 08:17:27 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 08:17:27 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH net-next 04/13] ipv4: Create cleanup helper for fib_nh Thread-Topic: [PATCH net-next 04/13] ipv4: Create cleanup helper for fib_nh Thread-Index: AQHU5E1avbFYzf31Vki0EUQqMIrs86YfImgA Date: Wed, 27 Mar 2019 08:17:27 +0000 Message-ID: <20190327081724.GD12504@splinter> References: <20190327032942.20473-1-dsahern@kernel.org> <20190327032942.20473-5-dsahern@kernel.org> In-Reply-To: <20190327032942.20473-5-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5P190CA0016.EURP190.PROD.OUTLOOK.COM (2603:10a6:206:14::29) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44f8480d-67a6-4686-93f0-08d6b28ca61d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB4337; x-ms-traffictypediagnostic: AM0PR05MB4337: x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(376002)(39850400004)(366004)(346002)(136003)(396003)(199004)(189003)(26005)(5660300002)(25786009)(14454004)(6486002)(8936002)(71190400001)(68736007)(486006)(102836004)(386003)(99286004)(6506007)(4744005)(97736004)(33656002)(81166006)(229853002)(105586002)(86362001)(6246003)(316002)(81156014)(1076003)(256004)(106356001)(54906003)(8676002)(4326008)(9686003)(305945005)(11346002)(478600001)(3846002)(7736002)(476003)(6916009)(6116002)(6436002)(33716001)(53936002)(52116002)(71200400001)(186003)(76176011)(446003)(6512007)(66066001)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB4337;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: d5Wl8lCJz4uWiUIhLWt4HNu+rh+Aa8K8flkDNBPV0g5H8+ixv9EjW2xCiYlke/zoxbnoB35pygiFIFVkvDlFMcKPJmXlqiu4s1qKDKzqFcHSXngp+5UcZclIP7QXYwhc83xBlnSt6TX7cTIdWQvR2Ek4H/FBiqWmrSuqLQ4si/PxajR1Yuy8x85ZnGExwGwSM8A3sHzGbV7vmM7jjQIVP2uyOzp7i3ZrKX8ZN2qNojYXAiL/ze1jq/7ehY2HyPyXNiJsI/HDHGD9FJ00l9pKHf7PFiZSsa6CCvXon3b+ygYKSnUtcyQggVnCP2D1eGOO8+DQv12Ron5EVdwnTKA+S4wZaGjZF/S+plZkOiqVGORQ48cYMusKWi5Y5l6qpbgyYE0mjFyfSdRQehREoDgopK2evhb9gAC84SSgRyioj+o= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44f8480d-67a6-4686-93f0-08d6b28ca61d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 08:17:27.4037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4337 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 26, 2019 at 08:29:33PM -0700, David Ahern wrote: > From: David Ahern >=20 > Move the fib_nh cleanup code from free_fib_info_rcu into a new helper, > fib_nh_release. Move classid accounting into fib_nh_release which is > called per fib_nh to make accounting symmetrical with fib_nh_init. > Export the helper to allow for use with nexthop objects in the > future. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel