From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689E5C43381 for ; Wed, 27 Mar 2019 09:19:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 326C42075C for ; Wed, 27 Mar 2019 09:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="SwZZoSVr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731509AbfC0JTV (ORCPT ); Wed, 27 Mar 2019 05:19:21 -0400 Received: from mail-eopbgr30069.outbound.protection.outlook.com ([40.107.3.69]:19776 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725768AbfC0JTV (ORCPT ); Wed, 27 Mar 2019 05:19:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K530HOW2SW4oD7bkwJLutr+E/oUOuFYXONKDuKBqQBM=; b=SwZZoSVrL3hr8nL6oQ2qbgD9G1qF0oDe2/ZxNq41AwWUGBBaIYRX+jzLx5Nl4zIGScKt269WDXw28vTztb+xSiGPZYZF4MwAjUJEU2PO9lkqFMvWAPBHp7q7B1qWAo9+HNSTALaILzCvQPQrLFdr6IC9rV+Z72GJuoXebfFdzFk= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB4707.eurprd05.prod.outlook.com (52.133.58.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Wed, 27 Mar 2019 09:19:17 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 09:19:17 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH net-next 08/13] ipv6: Refactor fib6_ignore_linkdown Thread-Topic: [PATCH net-next 08/13] ipv6: Refactor fib6_ignore_linkdown Thread-Index: AQHU5E1a29oRbSSrTUaiVDvEA3A0YKYfM68A Date: Wed, 27 Mar 2019 09:19:17 +0000 Message-ID: <20190327091914.GA16487@splinter> References: <20190327032942.20473-1-dsahern@kernel.org> <20190327032942.20473-9-dsahern@kernel.org> In-Reply-To: <20190327032942.20473-9-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::36) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 124f9581-f2c3-49d1-c193-08d6b2954929 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB4707; x-ms-traffictypediagnostic: AM0PR05MB4707: x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(376002)(39860400002)(136003)(346002)(366004)(189003)(199004)(229853002)(25786009)(97736004)(2906002)(7736002)(305945005)(66066001)(33716001)(486006)(54906003)(446003)(6916009)(14454004)(6486002)(476003)(5660300002)(11346002)(256004)(4326008)(68736007)(6246003)(8936002)(186003)(86362001)(4744005)(76176011)(386003)(6506007)(33656002)(71200400001)(71190400001)(6116002)(52116002)(102836004)(6436002)(99286004)(53936002)(26005)(106356001)(478600001)(1076003)(105586002)(9686003)(6512007)(8676002)(316002)(81156014)(3846002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB4707;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Fz2Z1Ne1006hXfzFjiCaI3ktlTIr/vQMG1y2eM2twVJ5giSjrPLihwKWYojAXc9GuCexqI6OQC714mvmBNcasH9XpLZcKJxIFWp1d7P/alKZ3I0R4iaP3tzZuomonafq3NhvNVJy3XmeyQO5jaWJpc6JSLGQOFkEhHGYQS0vtKlUw48VqzDh5+NW6kAuBIaUXvXQeL07meJw4Y7e9gTw5QGJsBtmn0ELVVhY3UKhrrsxTtr3mO0X9qpRmAXmpVPLdwIIjyfDp6tEeTk8XGoBqbHadzNiKuQl0BHOua+66/dN94hIZbw7qaNBue5leq7TuuC1mFeOArEsuTAFOhSH9w57SHND5yJ5NscMkzjv4FJ7R7BW8Ulywouq8sY/07uUBdWeibSs7cqijn7aW5wXHS+1h5rfGRbkD06TED1qVO8= Content-Type: text/plain; charset="us-ascii" Content-ID: <469076A1D6552D4AAF1CCDEDD5D02CB5@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 124f9581-f2c3-49d1-c193-08d6b2954929 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 09:19:17.2962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4707 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 26, 2019 at 08:29:37PM -0700, David Ahern wrote: > From: David Ahern >=20 > fib6_ignore_linkdown takes a fib6_info but only looks at the net_device > and its IPv6 config. Change it to take a net_device over a fib6_info as > its input argument. >=20 > In addition, move it to a header file to make the check inline and usable > later with IPv4 code without going through the ipv6 stub, and rename to > ip6_ignore_linkdown since it is only checking the setting based on the > ipv6 struct on a device. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel