From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF92C43381 for ; Wed, 27 Mar 2019 10:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E35E20700 for ; Wed, 27 Mar 2019 10:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553681746; bh=ZSNP1n57JpkRWY2ObhCK+TIWySMFjXB7cUEgiavy7VY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DGdecoaIIS1ibZRhs1SeC6gPGXKzybh+ii4HIen4pK2LJBceaTSnwtNCplcrOFPt0 Wq4oEjOXtgmzC3Q9DC/9vcyHZFXmGDFsPCj5WFLlADx/LIY/owluWkAgl3Q94CWG8p 6vP2D0XOYZ/1/OgL5D+fl3rVokeCYS6Svu/ycpsI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733036AbfC0KPp (ORCPT ); Wed, 27 Mar 2019 06:15:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732917AbfC0KPo (ORCPT ); Wed, 27 Mar 2019 06:15:44 -0400 Received: from localhost (unknown [49.207.63.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AD6920700; Wed, 27 Mar 2019 10:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553681744; bh=ZSNP1n57JpkRWY2ObhCK+TIWySMFjXB7cUEgiavy7VY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zuiPV3S0lDBqANxujCfowk6jOHzpsKx7C2y5DujWmQkCPbQ4OIaTViAuLSfmhEaFn qhFNh93Q82OSY3i1t7OPc0SkuftJuXYY+Pmd9UGddc4GiyNCfM94nYb0kcby5d4E60 Swob44KrPxeEg09cPlEv8qaL0BHTowkO1uYXRgTY= Date: Wed, 27 Mar 2019 15:45:39 +0530 From: Vinod Koul To: xiaofeis Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, niklas.cassel@linaro.org, xiazha@codeaurora.org Subject: Re: [PATCH] net: dsa: Implement flow_dissect callback for tag_qca Message-ID: <20190327101539.GA5348@vkoul-mobl> References: <1553659146-44406-1-git-send-email-xiaofeis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1553659146-44406-1-git-send-email-xiaofeis@codeaurora.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27-03-19, 11:59, xiaofeis wrote: > Add flow_dissect for qca tagged packet to get the right hash. Ideally this patch should have been tagged as V2. Anyhow the change looks fine so: Reviewed-by: Vinod Koul > Signed-off-by: Xiaofei Shen > --- > net/dsa/tag_qca.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c > index e886a3c..f4b4de3 100644 > --- a/net/dsa/tag_qca.c > +++ b/net/dsa/tag_qca.c > @@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff *skb, struct net_device *dev, > return skb; > } > > +static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto, > + int *offset) > +{ > + *offset = QCA_HDR_LEN; > + *proto = ((__be16 *)skb->data)[0]; > + > + return 0; > +} > + > const struct dsa_device_ops qca_netdev_ops = { > .xmit = qca_tag_xmit, > .rcv = qca_tag_rcv, > + .flow_dissect = qca_tag_flow_dissect, > .overhead = QCA_HDR_LEN, > }; > -- > 1.9.1 -- ~Vinod