From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61CEFC43381 for ; Wed, 27 Mar 2019 13:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 326E5206DF for ; Wed, 27 Mar 2019 13:04:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="bkH0m9SD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730878AbfC0NEc (ORCPT ); Wed, 27 Mar 2019 09:04:32 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35112 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728101AbfC0NEb (ORCPT ); Wed, 27 Mar 2019 09:04:31 -0400 Received: by mail-wr1-f68.google.com with SMTP id w1so18529605wrp.2 for ; Wed, 27 Mar 2019 06:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=crf1Iecu3EOEPIAilP0B17w6/ntCR3m+XRl1tzv0Lek=; b=bkH0m9SDwm9Uw2UujNsQbl7tcQUwj2HqYbF1eHksp8PReaG/yRIvJojVadxen3wxEW 1jq44Ud9sZvKizEvcRg5EIIFSWNFRAoQ99TIidDZ/1l4SiJj+NOGb6WM4EV/OwKPxDtf F9Zbz522SaeBqPPammzpkeTLUbhEKp/Em/KcZAkA4TBZ8OsaxOoq+MTW0oaKjqiNzCIf wt3mPJkOwfaFsjoosoaKNj2G8VNRRJlBkurI+fMh7ANGixWs3TnQBkk+aLcO2rJ2/NXR iJu1mBxHRhsvLVnfzcB204pSEWqmlB/eNkWjj2N+50erchBZDZTzrvC48MltXEYnSvK2 KhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=crf1Iecu3EOEPIAilP0B17w6/ntCR3m+XRl1tzv0Lek=; b=eStdF+ar7wHlfoSEpdhm8wzsw+TrjqL6k7PIuz1R9KF075oy/Srk0m/0RECvjptax3 jbcl/CSWv2o3k1gI/4cXe9qT7wdkg3HxYCynZQux4p9uvQrDrFQgWKmB6oUra/wfdRLV AghVfKcFuH1Q4VsH8dWfNx9YL+Dpmh3yCR5bQ0UOgZ6ABPFhWnRpISdagA5mWA9Sb7xn goQ/BgUHoaB34Ex8onqfsLl0ENTZ3xrJRO4dxbvQyt7neWq2rP+Bs5poegPCHtELlp/T diFbc049OxjS/ZoJ0nDigXvd9cHmC9BSbLZvxQs4vakG2qOk/iUaT+W+iRjhwFUuiiBu fGKA== X-Gm-Message-State: APjAAAVUbP1KsHqOtw5B43Hhl+Q0MAPDUxX9iqAouWBY8eB1bUK0H+Sw 4LgrhdbWbiAXPXb9Kips53Ge1w== X-Google-Smtp-Source: APXvYqz0bzT9UX6YiZMsMIdPGjpQ4ivmAYhOjG1oa0D3n7BbzWhCGLvfuw4t2oeQi+/gHzdSfXGUKg== X-Received: by 2002:a5d:6b4a:: with SMTP id x10mr22874279wrw.63.1553691869937; Wed, 27 Mar 2019 06:04:29 -0700 (PDT) Received: from localhost (ip-94-113-223-73.net.upcbroadband.cz. [94.113.223.73]) by smtp.gmail.com with ESMTPSA id a22sm1752102wmj.44.2019.03.27.06.04.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 06:04:29 -0700 (PDT) Date: Wed, 27 Mar 2019 14:04:28 +0100 From: Jiri Pirko To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 09/22] ethtool: implement EVENT notifications Message-ID: <20190327130428.GB14297@nanopsycho> References: <971a93b567c81103716902cd1ad00946201f9710.1553532199.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <971a93b567c81103716902cd1ad00946201f9710.1553532199.git.mkubecek@suse.cz> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Mar 25, 2019 at 06:08:21PM CET, mkubecek@suse.cz wrote: >Three types of netlink notifications are introduced: > > - ETHA_EVENT_NEWDEV to notify about newly registered network devices > - ETHA_EVENT_DELDEV to notify about unregistered network devices > - ETHA_EVENT_RENAMEDEV to notify about renamed network device > >The notifications are triggered by NETDEV_REGISTER, NETDEV_UNREGISTER and >NETDEV_CHANGENAME notifiers. > >These notifications are intended for applications and daemons monitoring >ethtool events to allow updating the list of existing devices without >having to open another socket for rtnetlink. Wait. You duplicate events that are already going out through RTNETLINK. App should open RTNETLINK in order to get those. Other apps are doing that too. I don't think that duplications like this are desirable :/