Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

[Leon Romanovsky <leon@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

On Wed, Mar 27, 2019 at 01:58:17PM +0200, Or Gerlitz wrote:
> On Wed, Mar 27, 2019 at 1:41 PM Leon Romanovsky <leon@kernel.org> wrote:
> > On Wed, Mar 27, 2019 at 12:07:54PM +0200, Or Gerlitz wrote:
> > > On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky <leon@kernel.org> wrote:
> > > > From: Artemy Kovalyov <artemyko@mellanox.com>
> > > >
> > > > Delete initialization of high order entries in mr cache to decrease initial
> > > > memory footprint. When required, the administrator can populate the
> > > > entries with memory keys via the /sys interface.
> > >
> > > Please add here:
> > >
> > > This approach is very helpful to reduce the per HW function memory
> > > footprint in environments such as VMs. Before the patch we see
> > > consumption of 0.9GB per function and after the patch about 0.1GB
> > >
> > > > Signed-off-by: Artemy Kovalyov <artemyko@mellanox.com>
> > > > Signed-off-by: Moni Shoua <monis@mellanox.com>
> > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Reported-by:  Shalom Toledo <shalomt@mellanox.com>
> > > Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
> > >
> > > Lets push it into stable kernels, a Fixes tag here will cause that
> > > to happen more easily, so please consider that.
>
> > I'll add it at the "apply" stage.
>
> Just to make sure, by "add it" you mean the signatures, the text and
> the Fixes that?

Yes, of course.

>
> Also, is there any reason not to eliminate the mr cache pre-population
> all together?

AFAIK, pre-populated cache helps MPI application to start faster and
with out-of-box experience. Nobody seems to care enough to challenge
this internal assumption.

>
> Currently we consume 100-200MB per function after the patch which is
> also problematic for some
> environments.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]