From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C6EC43381 for ; Wed, 27 Mar 2019 14:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7283F2087C for ; Wed, 27 Mar 2019 14:46:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G+ZgN6nT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729793AbfC0OqJ (ORCPT ); Wed, 27 Mar 2019 10:46:09 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43225 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729114AbfC0Op6 (ORCPT ); Wed, 27 Mar 2019 10:45:58 -0400 Received: by mail-pl1-f196.google.com with SMTP id m10so3426262plt.10 for ; Wed, 27 Mar 2019 07:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=x4AoO57WHK/MYPvuGCmhxuDFGHngHPzzs/C0+HpF0ek=; b=G+ZgN6nTgN4TQxFA4sYYcPqCWeifBmy3cqim/KwV2xMItjmDc7eMc6MBviPaWrKlZM m3M7wse/SmlYMpZ07z0No+vP2zlVPQUv7emsRng7/ppYS/bzwTP3HQ1jja/Oll/4pUj5 9B7R5oUGoUitMFlw36PmvxuIzfTwvm72Buzjdf/NAhY4Cueq+JVcgaP/ThHjivTobF2A OSrlfyK+ZCZQYN1tR41A9vjazaXRVqhXxg7TfNPsdPcQEI1ZIidDbvElvwzcKW1B8+a5 9bWLEZcVJX8FLPD1OEApOBBUruGej9mihOKAxZERo+PT18J+F4Sz/ThAgvgB3m4CJTxz JLlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x4AoO57WHK/MYPvuGCmhxuDFGHngHPzzs/C0+HpF0ek=; b=k/Y0eKoVlKdIGHJ9P6LY1RCNjoNTCnLK5DnEixQgBkaEouIONxYnCaasUlWP7lAmWL JqSh4Ofz4f/cp3LzWzxZvileKO2JiWQaW7O8DGSIIK+TBIwnEH0bjYv5R9wPPEty1/o3 MRFI9AkKtfWbrvPL9kv6Pt/4oLwjFheYBN3KGdFMpB9mw5rMaCiSnShcCLWF/IuFxVjU 7oWESwHEXQ+or8NKPjkZFBSPh29MJv65LTLGOQ3FQ1JSFh+QRaW0vlEjdRA/k1u7MMUi Deyp/saC7VwUHYrfuTphpEEZ8Gnsw7SNS2l8tRhju1XGxCppaU/q84HkJrlt6y8zWtfX e7ZA== X-Gm-Message-State: APjAAAUQxS28pR3Rn813IxKJfuwZIj4FXHBA4EW3h+KfArspc7Bxn2ho TbNp0Oi5iPNr9byGKFhX4g== X-Google-Smtp-Source: APXvYqydYvMW14m/5476PmrzbKSyhEMmfgRBiCbbIvZYCyhDGTFJF7Axp+jq7ePyeo1xcFflMZ3zIg== X-Received: by 2002:a17:902:b60c:: with SMTP id b12mr36624343pls.261.1553697957485; Wed, 27 Mar 2019 07:45:57 -0700 (PDT) Received: from localhost.localdomain ([114.71.48.5]) by smtp.gmail.com with ESMTPSA id b63sm35844470pfj.54.2019.03.27.07.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 07:45:57 -0700 (PDT) From: "Daniel T. Lee" To: Daniel Borkmann , Alexei Starovoitov Cc: netdev@vger.kernel.org Subject: [PATCH v2 1/2] selftests/bpf: ksym_search won't check symbols exists Date: Wed, 27 Mar 2019 23:45:48 +0900 Message-Id: <20190327144549.6685-1-danieltimlee@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, ksym_search located at trace_helpers won't check symbols are existing or not. In ksym_search, when symbol is not found, it will return &syms[0](_stext). But when the kernel symbols are not loaded, it will return NULL, which is not a desired action. This commit will add verification logic whether symbols are loaded prior to the symbol search. Signed-off-by: Daniel T. Lee --- tools/testing/selftests/bpf/trace_helpers.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c index 4cdb63bf0521..9a9fc6c9b70b 100644 --- a/tools/testing/selftests/bpf/trace_helpers.c +++ b/tools/testing/selftests/bpf/trace_helpers.c @@ -52,6 +52,10 @@ struct ksym *ksym_search(long key) int start = 0, end = sym_cnt; int result; + /* kallsyms not loaded. return NULL */ + if (sym_cnt <= 0) + return NULL; + while (start < end) { size_t mid = start + (end - start) / 2; -- 2.17.1