From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Edward Cree <ecree@solarflare.com>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
Florian Westphal <fw@strlen.de>,
brouer@redhat.com, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH net-next] dpaa2-eth: use netif_receive_skb_list
Date: Wed, 27 Mar 2019 15:20:06 +0100 [thread overview]
Message-ID: <20190327152006.34dd31db@carbon> (raw)
In-Reply-To: <ab5c0620-e861-5921-dfed-7a30a51d369b@solarflare.com>
On Wed, 27 Mar 2019 12:02:13 +0000
Edward Cree <ecree@solarflare.com> wrote:
> On 26/03/2019 14:43, Jesper Dangaard Brouer wrote:
> > On Mon, 25 Mar 2019 13:42:39 +0000
> > Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> >
> >> Take advantage of the software Rx batching by using
> >> netif_receive_skb_list instead of napi_gro_receive.
> >>
> >> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> >> ---
> > Nice to see more people/drivers using: netif_receive_skb_list()
> >
> > We should likely add a similar napi_gro_receive_list() function.
>
> I had a patch series that did that; last posting was v3 back in
> November: https://marc.info/?l=linux-netdev&m=154221888012410&w=2
> However, Eric raised some issues, also some Mellanox folks privately
> reported that using it in their driver regressed performance, and
> I've been too busy since to make progress with it. Since you seem
> to be much better than me at perf investigations, Jesper, maybe you
> could take over the series?
I'm hoping Florian Westphal might also have some cycles for this?
(We talked about doing this during NetDevConf-0x13, because if we can
make more driver use these SKB-lists, then it makes sense to let
iptables/nftables build a SKB-list of packets to drop, instead of doing
it individually, and then we leverage Felix'es work on bulk free in
kfree_skb_list).
I'm currently coding up use of netif_receive_skb_list() in CPUMAP
redirect. As this makes is easier for e.g. Florian (and others) to
play with this API, as we no-longer depend on a device driver having
this (although we do depend on XDP_REDIRECT in a driver).
And the trick to get this as faster than GRO (that basically recycle the
same SKB) is to use the slub/kmem_cache bulk API for SKBs.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-03-27 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:42 [PATCH net-next] dpaa2-eth: use netif_receive_skb_list Ioana Ciornei
2019-03-26 14:43 ` Jesper Dangaard Brouer
2019-03-26 14:54 ` Eric Dumazet
2019-03-27 12:02 ` Edward Cree
2019-03-27 14:20 ` Jesper Dangaard Brouer [this message]
2019-03-26 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327152006.34dd31db@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=fw@strlen.de \
--cc=ioana.ciornei@nxp.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).