From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E1FC43381 for ; Wed, 27 Mar 2019 15:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 214942082F for ; Wed, 27 Mar 2019 15:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dQrNvGl3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbfC0PY5 (ORCPT ); Wed, 27 Mar 2019 11:24:57 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38825 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbfC0PY5 (ORCPT ); Wed, 27 Mar 2019 11:24:57 -0400 Received: by mail-pg1-f194.google.com with SMTP id j26so8089040pgl.5 for ; Wed, 27 Mar 2019 08:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ogKxRo02amqSX0/zLUKfokzrBXLstF6PwZz8FfCOn/s=; b=dQrNvGl3njhDKDHn9Cq85flAybFBTMAcaAciahjM6zSAlVFWyZqFfREU/xkR3UOgJA rIJn4VDzO8MxjkUg05iRkQJ+Hst3Au55vNajkTsrm2vqjyYUCwVANtw2jaYDNyA0nHfo /xdqaIYaeGnIJ0BjxynzHqcQGku1gUw2sQLAluQSa8sR95pomHNZ17hHhrVl3BG+PUS8 tdbz+MoSt7NG/RG8GAuNKBEmZ8mxQdegKEaqCNBGKlvgWG1PourinSwaIx7kDoKWkJwZ ++qnvda1Es8yBbEMmtukbuA3ThWnS2ibmtuSagSF/1UJFyySE/1Rfn2BBx5m7op/Qd1b jMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ogKxRo02amqSX0/zLUKfokzrBXLstF6PwZz8FfCOn/s=; b=iY7Sk5xpvaeUPtB5POzfAOe1mZ92gGr/boG5mmXXmIOXyiT2ABaHg0Dq6k43ghVhgQ 5TM/DQQVurnXZAyd7nLtsCKZ2XS52wTtNg2L7j0FByptxu8+kQJOKYeC6ufiGV1dhsIA 38gHq3snCMGVQah1IqH6dgL4Ux0j/MNsD80KL8VCwEDVIl6gWhqYKNYqSsQTKiVf+/AR vo6ZgBOg7laQmcRc6J0Lu7wizFuUhHcG6iz4IVCClinfa5k5+H4YimmEdH1qI6wHbbzv SeUIKddHALj7teiRHliuzFjYF+aw4Eofs6JW7qL8sfLfKCmighwHQT06neMid7R1Qp6F bEXQ== X-Gm-Message-State: APjAAAXqeEnHuje4W78xQlc5YGp5g2TCakOjnZPLSz6qXxap/e7Lzv7p 7GyZvmJxZupXD2TuTp50uo9OMw5n X-Google-Smtp-Source: APXvYqzwAJeZw4o6vJBEBCq8g7a3/KQv2O4Ik9sQh7d+HCV2OsVWclGVm5rQSCxsuQRiL6ztp0aClA== X-Received: by 2002:a63:65c4:: with SMTP id z187mr34447143pgb.102.1553700295934; Wed, 27 Mar 2019 08:24:55 -0700 (PDT) Received: from Inspiron-3521 ([2401:4900:369b:7f6a:5d4e:357e:5f86:c164]) by smtp.gmail.com with ESMTPSA id i22sm28787901pfa.88.2019.03.27.08.24.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 08:24:54 -0700 (PDT) Date: Wed, 27 Mar 2019 20:54:45 +0530 From: Leslie Monis To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob Message-ID: <20190327152445.GA5322@Inspiron-3521> References: <20190323184835.20456-1-lesliemonis@gmail.com> <20190323184835.20456-2-lesliemonis@gmail.com> <20190327075357.293922b3@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190327075357.293922b3@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 07:53:57AM -0700, Stephen Hemminger wrote: > On Sun, 24 Mar 2019 00:18:34 +0530 > Leslie Monis wrote: > > > tc_pie_xstats->prob has a maximum value of (2^64 - 1). > > > > Signed-off-by: Leslie Monis > > --- > > tc/q_pie.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tc/q_pie.c b/tc/q_pie.c > > index f7924ef5..6566ca10 100644 > > --- a/tc/q_pie.c > > +++ b/tc/q_pie.c > > @@ -198,7 +198,7 @@ static int pie_print_xstats(struct qdisc_util *qu, FILE *f, > > st = RTA_DATA(xstats); > > /*prob is returned as a fracion of maximum integer value */ > > fprintf(f, "prob %f delay %uus avg_dq_rate %u\n", > > - (double)st->prob / (double)0xffffffff, st->delay, > > + (double)st->prob / (double)0xffffffffffffffff, st->delay, > > This won't work correctly on 32bit systems because that value won't fit there.. You would be better off using UINT64_MAX Alright. I will correct this. Thanks