From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7B0C43381 for ; Wed, 27 Mar 2019 22:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C93802070B for ; Wed, 27 Mar 2019 22:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727569AbfC0WQ3 (ORCPT ); Wed, 27 Mar 2019 18:16:29 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:40534 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727390AbfC0WQ3 (ORCPT ); Wed, 27 Mar 2019 18:16:29 -0400 Received: by mail-qt1-f196.google.com with SMTP id x12so20842469qts.7 for ; Wed, 27 Mar 2019 15:16:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e/WWHIkO7jVEnDV7lLpAuPYGPmYxx6Weem9eWcPw+BQ=; b=kAOtZWeNPYcxRdODkmywDTUF5rawcbxt94iFupg2ahrjri0TGWeAYukKw0vqOEvL7z HoJjRMZ0ChnOLSAtrYhrdk2tuBfxTdwyqjkyEOf7bbT2yqF0e7yBsZ/XbAvHDOCHdqh6 XPSbPSd/FmN92H1M3l5i1cUkYBx4l5ix88bn5/Z6TEhT+MRsJYTI5RqzW2cBbbcnEOky 085wfuazsVfGTPa+M8aBqaBpliv/D6b4jlOuemE57c4i2EzhW9u0ciDabKUPH/VUuZ3T cNMAfcXRceTUbtYNYW7Y1FS2yl0JMWsPrLSc9FRuEeRwPj+XKHQioSfWb4rbploKsq9m Iuzg== X-Gm-Message-State: APjAAAW3SZdITIxLP3HqHiRe1T1nzuYJ9YbuI7ITIWmU/cPvBctV7AM8 P+PlFc43STYnTGjlNZpxPpAZyA== X-Google-Smtp-Source: APXvYqwGFcRo596tMtMN3QpyvttA19NTI/aUYUxRo4fYKXy4+uuIM4E5smKQbLHBKv+h9RL1WzFf2A== X-Received: by 2002:aed:29a5:: with SMTP id o34mr34226840qtd.145.1553724988362; Wed, 27 Mar 2019 15:16:28 -0700 (PDT) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id c207sm9911778qkg.14.2019.03.27.15.16.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 15:16:27 -0700 (PDT) Date: Wed, 27 Mar 2019 18:16:23 -0400 From: "Michael S. Tsirkin" To: si-wei liu Cc: Stephen Hemminger , sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v3] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190327181433-mutt-send-email-mst@kernel.org> References: <1553644093-10917-1-git-send-email-si-wei.liu@oracle.com> <20190326191342.11f0cb55@shemminger-XPS-13-9360> <20190327092424-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 01:10:10PM -0700, si-wei liu wrote: > Another less safer option is that we just notify userspace anyway without > sending down/up event around, as I don't see *any real application* cares > about the link state or whatsoever when it attempts to detect rename. How do you write a race ree handler then? ATM just detecting link up is sufficient and covers 100% of cases. Seems like a good idea to keep it that way. -- MST