From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED41BC43381 for ; Wed, 27 Mar 2019 19:44:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B28E620449 for ; Wed, 27 Mar 2019 19:44:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="pzNqRE5m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbfC0ToQ (ORCPT ); Wed, 27 Mar 2019 15:44:16 -0400 Received: from mail-eopbgr10064.outbound.protection.outlook.com ([40.107.1.64]:24701 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728203AbfC0ToQ (ORCPT ); Wed, 27 Mar 2019 15:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zKdpGHIyYj/FjJ5U2cvpUQ/3siFRkYly/ka5E9DOjNM=; b=pzNqRE5mx03eg+RA2tayPAI8pSsg/ojTmY0lYphEGN3YyURX5O+w0jo0kEhNsNHAf+buUgkBCBwt3Cbd23LdH22BVgH2GXco5CoTfNe073LSoa8DtdAJ0hR2/KqB3l7SfhHk0ViDO8XCDsSDiuHuZZLO1w+exC9hNMQ1rIpEVfs= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB5731.eurprd05.prod.outlook.com (20.178.115.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Wed, 27 Mar 2019 19:44:11 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 19:44:11 +0000 From: Ido Schimmel To: Jakub Kicinski CC: Petr Machata , Jiri Pirko , "netdev@vger.kernel.org" , "davem@davemloft.net" , Shalom Toledo , mlxsw Subject: Re: [PATCH net-next 2/2] mlxsw: core: Add support for devlink info command Thread-Topic: [PATCH net-next 2/2] mlxsw: core: Add support for devlink info command Thread-Index: AQHU49pOtMpWuzM01EOTyE/364bNuqYehECAgADZrwCAAIflgP///VOA Date: Wed, 27 Mar 2019 19:44:11 +0000 Message-ID: <20190327194403.GA7415@splinter> References: <20190326134535.3826-1-idosch@mellanox.com> <20190326134535.3826-3-idosch@mellanox.com> <20190326134807.39378e14@cakuba.netronome.com> <878sx0hcnz.fsf@mellanox.com> <20190327105337.7f1f97a8@cakuba.netronome.com> In-Reply-To: <20190327105337.7f1f97a8@cakuba.netronome.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LNXP265CA0094.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::34) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [79.176.7.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98dacab0-702c-4a97-5f6e-08d6b2ec956c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB5731; x-ms-traffictypediagnostic: AM0PR05MB5731: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(376002)(39860400002)(136003)(346002)(366004)(396003)(199004)(189003)(4744005)(6246003)(105586002)(966005)(256004)(1076003)(229853002)(6486002)(6436002)(106356001)(71190400001)(97736004)(8936002)(5660300002)(11346002)(476003)(446003)(66066001)(71200400001)(486006)(3846002)(186003)(6116002)(54906003)(99286004)(107886003)(14454004)(4326008)(26005)(25786009)(52116002)(2906002)(76176011)(316002)(33716001)(6506007)(102836004)(386003)(7736002)(53936002)(478600001)(33656002)(6512007)(86362001)(305945005)(81156014)(6306002)(8676002)(81166006)(9686003)(68736007)(93886005)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB5731;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ypJlNFjytHf0evZ6EWPNH+b4ffGaQLCcVhvhICnEz3CNedIEXVO10tvz/7F9vza1CMbZxdAh6q4N9qlvLLfSUFq4O7lkP5FUbTLA7HJDvWLZCYfaV9Q11BC+aL0Ycd0lXXUny8P/Jzi/Q6IPcift0nLEeTOaUiIGnqrWpYuLpf2P+oHoVVIOFxPcutH1OzIlw2mturyQJTUweuYF/bbTHN1C+bfw1qeX4cQQY2nBFq4dLdx4kcQ3JMLgz8iCbJt0CG88tBXMZ13RTp7ma3SewWYsZWtW140hqcL2Zm9wMNNQBuXrqLc1LdC9WYAFEYjGFpvvnWHOWzdh4cAfq0AhSilUqfquXiEUThLgvRIvpY0p0t2uEhQYf/AgylCn72kq+jO8vVbcT9me6ge/YZQLxtEjl2HgFB9beo/FOfygYEU= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98dacab0-702c-4a97-5f6e-08d6b2ec956c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 19:44:11.3761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5731 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 10:53:37AM -0700, Jakub Kicinski wrote: > On Wed, 27 Mar 2019 09:47:14 +0000, Petr Machata wrote: > > Jakub Kicinski writes: > >=20 > > > Looks good & glad to see it, but what's a PSID? ;) > > > > > > I found this after 5 seconds of googling: > > > > > > http://www.mellanox.com/page/firmware_HCA_FW_identification > > > > > > But it still just say "PSID" without explaining what the acronym stan= ds > > > for :) =20 > >=20 > > "Parameter Set ID" > > http://www.mellanox.com/pdf/MFT/MFT_Windows_user_manual.pdf >=20 > Thanks, would it be okay for you guys to spell that out, or at least > add a description to the doc? Hopefully that can help with reuse and > on the flip side avoiding using the same acronym for completely > different things.. OK. We can add fw.psid to Documentation/networking/devlink-info-versions.rst