From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B11BC43381 for ; Wed, 27 Mar 2019 20:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E66B62147C for ; Wed, 27 Mar 2019 20:01:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="BdN6pjL7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727595AbfC0UBZ (ORCPT ); Wed, 27 Mar 2019 16:01:25 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:47024 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727117AbfC0UBZ (ORCPT ); Wed, 27 Mar 2019 16:01:25 -0400 Received: by mail-wr1-f67.google.com with SMTP id t17so3411087wrw.13 for ; Wed, 27 Mar 2019 13:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H7fWWmhwx9ZSodB2B2lTHy78XhhSXgBZW+Bt6hUzw8w=; b=BdN6pjL7YQgeZb6ek7afPOJgWmHGv3a8Nul+aj3s1TgPK99cfnYLHNA2sTwAuPPTgg zcQJNaS98cnEwbak0P0nLLXd+Dz1604AqcuoWpFS+qF2KLGjihMv5GjRo4GDkMb4Sy8p 995s4oQkkIv7LI5No+bIGGRnKF+7RvZuZyZx21rwjMgffaIARLOWWSSNMeubP9m3FfmH ancmEwXR81F/5dE8CuPPg7qA2NW75a1vJIHcSx1XYyljVtdl14jTxAzcmPh+AvAD5lUo 98jFHwwB8rNeovXwIP96tCXGtcw8U5McgzhldOBvfM9fJi9ZLDDb+G3VBXgp10Za9v+q W57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H7fWWmhwx9ZSodB2B2lTHy78XhhSXgBZW+Bt6hUzw8w=; b=sDP9sSzfrCSrVqOY8TZJd+X1QbrS1QihkM64g8Lxr66iL8UMfnAb4hWg4NSgRtg1PI qHgOMJMsFshjTyX4HSDN0Btd8bh5/J/h3ngIzC68yOxJaqvoOEXsZMnvuVRh0mMboEUA eqJ7r6f7tNjhxaVRFiAnoUr4Ifj8ZuGYsnDqT5unyYAeMtGxtFKo2yRtvdbh7ykWmY4N c237N1gpXeKMZWwPBnfiIRjbDJN+0KTA8NkD4NV6EbG/A7Za+wKAP8Bk3QNuY6eZVw0p +REs08A3KEQ2j8DaMyvm0nFfloiKTvCoKLFlpana5NGiDSDakgOcdFcTs+oxYVPsbibs 7T0A== X-Gm-Message-State: APjAAAUsovZnwS2NDyRkylCnxPDGaqopPr5jdBMSorxt/6eStj3fKHgK uGBIL/WAyntYqRQUN69vL8D72wTwdC4= X-Google-Smtp-Source: APXvYqw5SpfXTOIwbdooujyu/jiLVJgyOnM94WJnsC9MeoOSAkB1RUMCSrZMpsjqmvG/4LC1oSMPOA== X-Received: by 2002:adf:e2d1:: with SMTP id d17mr23525955wrj.243.1553716883604; Wed, 27 Mar 2019 13:01:23 -0700 (PDT) Received: from localhost (ip-94-113-223-73.net.upcbroadband.cz. [94.113.223.73]) by smtp.gmail.com with ESMTPSA id e9sm21022862wrp.35.2019.03.27.13.01.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 13:01:23 -0700 (PDT) Date: Wed, 27 Mar 2019 21:01:22 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port Message-ID: <20190327200122.GF14297@nanopsycho> References: <20190326120307.2953-1-jiri@resnulli.us> <20190326120307.2953-9-jiri@resnulli.us> <6477e604-0b6a-fa49-920f-9a1fd4478dbb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6477e604-0b6a-fa49-920f-9a1fd4478dbb@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Mar 27, 2019 at 08:54:41PM CET, f.fainelli@gmail.com wrote: >On 3/26/2019 5:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> In order for devlink compat functions to work, implement >> ndo_get_devlink_port. Legacy slaves does not have devlink port instances >> created for themselves. > >Not a big fan of de-duplicating the entire set of netdev_ops for legacy >vs. non-legacy, can we just check that the devlink instance was r In nfp, I make legacy and non-legacy ndos to be shared. However there, they are doing to eventually all use devlink ports. In dsa on the other hand, I don't think that legacy is going to use devlink port, would it? I wan't to eventually have WARN_ON in devlink code in case devlink_port exists and phys_port_name ndo is present at the same time.