From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD4DC43381 for ; Thu, 28 Mar 2019 02:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B78BE2075C for ; Thu, 28 Mar 2019 02:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jqyisu82" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728033AbfC1C3y (ORCPT ); Wed, 27 Mar 2019 22:29:54 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40890 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726891AbfC1C3y (ORCPT ); Wed, 27 Mar 2019 22:29:54 -0400 Received: by mail-pl1-f195.google.com with SMTP id b11so4218163plr.7 for ; Wed, 27 Mar 2019 19:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9GkvJCbNH8AQkOBW3Z2SIIPmyYmismaSXn407Je3Sz8=; b=Jqyisu82LDxMKBHxx2CVgkcNWZyr2u0xc51xBuj2UTkEpWUO1YumJ70b0Hc3MeSLf0 rFGjW9pxifbajIGo++hw32Or6O0j7/FcfPO9DD06RL1GCI+qxKxSjHzFsyj0hnFm5tgp Ru2qRpeQrH+jeT5w/tTmyNKK4x2b9vmyLl8rJHY3k45HOmCUFbvVyFFPca6Vj7wvTG97 iGjKCdhrDF+HxUBjfnfJqJIYZs+eFvcLDmrUqVKMnYo9w7BkH7xVh82/PjbiKfghc+r3 vLf88BkygyC/L21FGg7CZIFxfKyXuYE1mkqmUYzbP7rEDKpkK5zZlvelcqx0lkW6iChA wSfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9GkvJCbNH8AQkOBW3Z2SIIPmyYmismaSXn407Je3Sz8=; b=nlRQMAshIJ7Z72a3R5irpecdXIyIpeGBa30SekhO0ggF2ShjYjBZtqvkse7PXI9SL4 p9fUCLqKysqNtO1Xyuh2R27g1beGUjOGm0e6hOTyMZS4Sl0uzl1j6wjneeHgGaFvdVE2 A0qkU2tems3ANA+g8IMG3wsomrfUW18Jepl3V3nH681MHC4QDM+Xa3IcT3rdCl62YUX+ QNE/0SbHhFdSB3az5damAb2cBoG6prx7f5KrYEDbScyA+ez8wkrxTIC+6om7YH6rGw5a JrH/Maom+2dGPe1L9w96ImEB1ooRw7CkS1TVMy65FM0CrY68fyAWtfGDDxvRF0kQJ7zJ Empw== X-Gm-Message-State: APjAAAWsshwtxWdlFy9O4d6Cyg5KW5TfH0d/+AU/zvTne/g2P0IBshvc /PqNqTbfxyQiVOzJokbx70c= X-Google-Smtp-Source: APXvYqyySNukAeqNZZMMyyKhrZeQA72WcDjq7aq+rQ8J5njQ80mxahAwWNYwF16fwJdmcTMSuldN/w== X-Received: by 2002:a17:902:407:: with SMTP id 7mr40576849ple.62.1553740193578; Wed, 27 Mar 2019 19:29:53 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:180::27f1]) by smtp.gmail.com with ESMTPSA id p14sm42036334pgn.34.2019.03.27.19.29.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 19:29:52 -0700 (PDT) Date: Wed, 27 Mar 2019 19:29:51 -0700 From: Alexei Starovoitov To: David Ahern Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh Message-ID: <20190328022949.rolbfyk5bkcib3jr@ast-mbp> References: <20190327182329.18149-1-dsahern@kernel.org> <20190327182329.18149-6-dsahern@kernel.org> <20190327225210.kbpivej33a72adwq@ast-mbp> <8e0e2afc-c8e7-8728-7b4d-f9c64987d46a@gmail.com> <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> <51a3d3fa-e0c1-ca40-8c25-659487a092f7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51a3d3fa-e0c1-ca40-8c25-659487a092f7@gmail.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 08:05:03PM -0600, David Ahern wrote: > On 3/27/19 7:30 PM, Alexei Starovoitov wrote: > >>> > >>> imo it would be cleaner not to mess with cfg. > >>> Ideally it should be marked 'const'. > >> > >> Existing code sets those flags but on a fib6_info. This is not used for > >> nexthop objects and is kept here to not duplicate this if branch in the > >> create_info that uses it. This check affects both which device is used > >> as well as the flags. > > > > What stopping you from doing fib6_nh->nh_flags |= RTF_REJECT | RTF_NONEXTHOP ? > > cfg should really be const. > > Because it is not a nexthop flag, it is a prefix flag. that was a typo. I meant fib6_flags. why mess with cfg and use it as weird side effect only to get rt->fib6_flags = cfg->fc_flags; working after fib6_nh_init() returns? Why not to move that fib6_flags = fc_flags assignment into fib6_nh_init ? Then cfg can stay constant and no weird side effects from init function.