From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BCA0C43381 for ; Thu, 28 Mar 2019 03:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ABD52075E for ; Thu, 28 Mar 2019 03:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VUC79THq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727981AbfC1DEp (ORCPT ); Wed, 27 Mar 2019 23:04:45 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:40013 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfC1DEp (ORCPT ); Wed, 27 Mar 2019 23:04:45 -0400 Received: by mail-pg1-f193.google.com with SMTP id u9so10893768pgo.7 for ; Wed, 27 Mar 2019 20:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IwreECkLNf/BZusStF2Ros2qGlYmr+dSCCDnanik4Fg=; b=VUC79THqLLuMRnizM4i1ijfM4hDTx+mctZykiWYF5NnOTZkok5zsn3Iveu3H4rWCVN 67yh2lUIQ3pQW4QTej+FZgPOrHt5N0sg1LUjUZSPIyb6GnX9MlicljN1QyEXpnQhMLug L9uc4WrGL3c48V+qmAzmTB15bEtdSiLDLYV8fjig19Sez4R+BXabmLbd+KUyhi5+10c7 XubzcNFHrljkSU18VBh+A2RPB1vWkTGvbFG9k3ctNOK0ClHmqa5KUMd7vQbyacNifQY8 pfsw5+IwbP9D7NCVJKbdQtftIn4XwURmWaJZxB1norYvyRTe+U6DuN4IOoH64cKZrW59 ITow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IwreECkLNf/BZusStF2Ros2qGlYmr+dSCCDnanik4Fg=; b=KZokcAwSdJWv7ySOhXlwRGgiFZIpPN5T5YWmHNZJkUbUnLg0m9kYDl/hXyaycx5DTW N0ygZx3IKsMkoyP6uB4ojBWPx3AkqHlLKpqCAOOcOWtdC94SKTUfyJP6mGat354GYeqz entGSnOyTa3LcXNTfLT0mItRXBttc04J7j/6PboO0YocN0EYhwOwHMlJ4uU/nj1jLp9w zPChOIghSW6LUZfxDAyQ1EkDajQwQEn2WFCwlgO+4xJY0tdu87dv1zlwk2zYv5uWPsgu kkjteit4sA7DwtSI6aBZW99hyP2zIzWHrFJlQc6YgTHJgPH2qZFK+OZrtl89XHkey+P8 fBmw== X-Gm-Message-State: APjAAAUd6jcp5p/Pew35n30PWaRl/MhGg7MHRWUHaunywxhnpz/+jXN/ lujjxAjlNzFnuNSGb2cDqLc= X-Google-Smtp-Source: APXvYqz3MUA8E+1bT0WmkM86l4u1uWz4mmZmA8YVaEm/ohB5eO4zTpFWtqEW5oNI0J10i8wS7px7uw== X-Received: by 2002:a62:1d90:: with SMTP id d138mr3507553pfd.232.1553742284841; Wed, 27 Mar 2019 20:04:44 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:180::27f1]) by smtp.gmail.com with ESMTPSA id u20sm27608241pga.76.2019.03.27.20.04.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 20:04:44 -0700 (PDT) Date: Wed, 27 Mar 2019 20:04:42 -0700 From: Alexei Starovoitov To: David Ahern Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh Message-ID: <20190328030440.ez355v7r7vvwww4u@ast-mbp> References: <20190327182329.18149-1-dsahern@kernel.org> <20190327182329.18149-6-dsahern@kernel.org> <20190327225210.kbpivej33a72adwq@ast-mbp> <8e0e2afc-c8e7-8728-7b4d-f9c64987d46a@gmail.com> <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> <51a3d3fa-e0c1-ca40-8c25-659487a092f7@gmail.com> <20190328022949.rolbfyk5bkcib3jr@ast-mbp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 08:50:19PM -0600, David Ahern wrote: > On 3/27/19 8:29 PM, Alexei Starovoitov wrote:]\ > > that was a typo. I meant fib6_flags. > > why mess with cfg and use it as weird side effect only to > > get rt->fib6_flags = cfg->fc_flags; working after fib6_nh_init() returns? > > Why not to move that fib6_flags = fc_flags assignment into fib6_nh_init ? > > Then cfg can stay constant and no weird side effects from init function. > > > > Because fib6_flags is not a nh_init argument and it should not be. > > I will duplicate that check to appease your request of not touching > cfg->flags. not sure what you meant by 'dupulicate that check'. If you're think about copy-pasting the whole 'if ((cfg->fc_flags & RTF_REJECT)' check that it's not nice either. If I read the patch correctly it's essentially initializing fib6_nh and fib6_flags. Both are part of rt. So either pass both pointers or pointer to rt. Why not?