From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44AAC43381 for ; Thu, 28 Mar 2019 11:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2D6221773 for ; Thu, 28 Mar 2019 11:17:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="VVK7ywxa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfC1LRj (ORCPT ); Thu, 28 Mar 2019 07:17:39 -0400 Received: from mail-eopbgr150082.outbound.protection.outlook.com ([40.107.15.82]:30337 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725987AbfC1LRi (ORCPT ); Thu, 28 Mar 2019 07:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slR76UtTRsAAMadj9S/S77RS6QRd/O67Fzo6pw4Ogf0=; b=VVK7ywxaoDEbC+35A41R3Py+6TMAbVq4uZuN+p6nV8FoCpnNwYGiR0viiQEWxdSvGbW8IOIhee6hPrXbx75DEguqx/rgbooQbqkUWCWVFBC5/QSct8gGP5JLf1OisCy4GcWtXEJ3bwxM4oymD6Fdw4MrSr/Bus9AjIuwNYsdBDY= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB5314.eurprd05.prod.outlook.com (20.178.18.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Thu, 28 Mar 2019 11:17:35 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Thu, 28 Mar 2019 11:17:35 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH v3 net-next 05/13] ipv6: Create init helper for fib6_nh Thread-Topic: [PATCH v3 net-next 05/13] ipv6: Create init helper for fib6_nh Thread-Index: AQHU5RpEAxRFPUd07kOgt4iFm9xm7aYg5XcA Date: Thu, 28 Mar 2019 11:17:35 +0000 Message-ID: <20190328111732.GA19672@splinter> References: <20190328035358.4929-1-dsahern@kernel.org> <20190328035358.4929-6-dsahern@kernel.org> In-Reply-To: <20190328035358.4929-6-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0336.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::36) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26b33116-15e9-4fb0-51d7-08d6b36efa79 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB5314; x-ms-traffictypediagnostic: AM0PR05MB5314: x-microsoft-antispam-prvs: x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(39850400004)(376002)(346002)(136003)(366004)(189003)(199004)(6916009)(3846002)(1076003)(4744005)(316002)(386003)(76176011)(6506007)(33716001)(102836004)(81156014)(52116002)(476003)(5660300002)(71200400001)(446003)(8676002)(71190400001)(54906003)(6116002)(81166006)(256004)(11346002)(7736002)(6436002)(229853002)(8936002)(25786009)(186003)(6486002)(6246003)(53936002)(105586002)(9686003)(66066001)(478600001)(97736004)(99286004)(106356001)(33656002)(26005)(68736007)(305945005)(86362001)(14454004)(2906002)(4326008)(486006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB5314;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3Sd/20Wc21R4ohEGGKsg9h5j0FyMR8kAItCdul26+nfGD+p83nCEh0EO82ykR0dH4xaiMi+jaCL/+NY4TOLrD4+mPVoMBhssUGz8bM+Gww6h0AFW62TvfChUIDAF+qCjHTFEy/yJSLpXOzgIsDRqh+QXzOyuoKDXCdJzEYObdANjkiSJg5hTdd0k+BbvInF7+xocWEvS/fmWSnC7j87Zd++VH9C1UiKVIIyDY/L43OzKfYlNmU3qiHsIt0xn5L2wGLtPhIzVIsFxcyl9SC071q5q9/yG6RO5/ZSIDpqFEnvXGtzLGMRJ3usoNvVsVpejzp1QAZv/ZRuEorUuct/o7QEk5scN+7WNUGx1FZzawdNTKUSef0uCo+KgwOIPOx/pdtcAresSOt+H3uU4klwcrGLJvfjwkYYRh3zoD8l11BA= Content-Type: text/plain; charset="us-ascii" Content-ID: <017E6B3DC7D2804299CAC20E09608EAD@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26b33116-15e9-4fb0-51d7-08d6b36efa79 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 11:17:35.3746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5314 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 08:53:50PM -0700, David Ahern wrote: > From: David Ahern >=20 > Similar to IPv4, consolidate the fib6_nh initialization into a helper. > As a new standalone function, add a cleanup path to put lwtstate on > error. >=20 > To avoid modifying fib6_config flags, move the reject check to a helper > that is invoked once by fib6_nh_init to reset the device and then > again in ip6_route_info_create to set the fib6_flags. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel