From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB78C43381 for ; Thu, 28 Mar 2019 11:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46F982173C for ; Thu, 28 Mar 2019 11:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="ncx+qaU9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbfC1LUj (ORCPT ); Thu, 28 Mar 2019 07:20:39 -0400 Received: from mail-eopbgr60087.outbound.protection.outlook.com ([40.107.6.87]:38211 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725779AbfC1LUi (ORCPT ); Thu, 28 Mar 2019 07:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i7y5jOYfvoyO9dEX3Mk6Roow3jSWIp1IPjOeIugSGjk=; b=ncx+qaU9N6zq/xYjsG1tifSpWpARqSSYDGAaa+8CtesZYJW0rjlLwLOcooLxxGlAWnSSYCIj+ty96Xj0VkN35PWMzbgoiZlgbO6A+6Uky14i33WFXQzo50scRzOXiFpprxu+lbbuhE6yf/TL+C87HlXcD//QqIBrgXpMthfG7DY= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB4547.eurprd05.prod.outlook.com (52.133.60.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Thu, 28 Mar 2019 11:20:35 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Thu, 28 Mar 2019 11:20:35 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH v3 net-next 07/13] ipv6: Move gateway checks to a fib6_nh setting Thread-Topic: [PATCH v3 net-next 07/13] ipv6: Move gateway checks to a fib6_nh setting Thread-Index: AQHU5RpERNaJm7QB/EmmUl+CIqi8KaYg5k4A Date: Thu, 28 Mar 2019 11:20:35 +0000 Message-ID: <20190328112032.GC19672@splinter> References: <20190328035358.4929-1-dsahern@kernel.org> <20190328035358.4929-8-dsahern@kernel.org> In-Reply-To: <20190328035358.4929-8-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0193.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::13) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 034126e6-95b9-46d5-a106-08d6b36f65c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB4547; x-ms-traffictypediagnostic: AM0PR05MB4547: x-microsoft-antispam-prvs: x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(39850400004)(346002)(376002)(136003)(366004)(199004)(189003)(6436002)(1076003)(446003)(54906003)(33716001)(6116002)(3846002)(5660300002)(316002)(6916009)(2906002)(4744005)(9686003)(6512007)(4326008)(25786009)(478600001)(6246003)(14454004)(105586002)(99286004)(256004)(305945005)(71190400001)(7736002)(81166006)(386003)(81156014)(6506007)(53936002)(6486002)(106356001)(8676002)(52116002)(76176011)(186003)(8936002)(476003)(11346002)(229853002)(33656002)(26005)(68736007)(71200400001)(486006)(66066001)(97736004)(102836004)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB4547;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7QsDmAbCc+wXOJUt4uBHa6Iy+YJMBGUTClJF1eyKWAi5UGDWVBf5wO/vSqWcHIK2ABBTuwqLnLxL2nfq+94yJxPmbdDPz75uD0DEYrHo2Uraf+d6ck/LxDKJ5zyY3oHSkFZxZIMwFW8md43XYwaDuk4/P/gw07i5e/lnJXrMD58wEdz2jetJrm4oyNhhZlCGGC43D2PYKgWbBIrXgeNR7nkKIAv4GMLcElJmN8JaX8imfgNAMaq0RlNwgwBnr7PCehDjkSqvGgKHZEWSnn1UGRxV6I9DYZOdLyQU2BgJcBgp07YPbhRpYpUYICUW5wOa+9goEzt5hWjzjZShOImJmZUiUSAVNKAzgkUdJxh4R5GWsKFPQuz4+xXR1Qx8DKtNkNi5E56+fYV+f+yZYGtPjxXzw6PGZezfUGKoDfayOwM= Content-Type: text/plain; charset="us-ascii" Content-ID: <2ACC6BD9DC0CB248B059B39CE7B67FE0@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 034126e6-95b9-46d5-a106-08d6b36f65c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 11:20:35.3400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4547 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 08:53:52PM -0700, David Ahern wrote: > From: David Ahern >=20 > The gateway setting is not per fib6_info entry but per-fib6_nh. Add a new > fib_nh_has_gw flag to fib6_nh and convert references to RTF_GATEWAY to > the new flag. For IPv6 address the flag is cheaper than checking that > nh_gw is non-0 like IPv4 does. >=20 > While this increases fib6_nh by 8-bytes, the effective allocation size of > a fib6_info is unchanged. The 8 bytes is recovered later with a > fib_nh_common change. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel