From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CE0C43381 for ; Thu, 28 Mar 2019 11:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C50292173C for ; Thu, 28 Mar 2019 11:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="X4jbNwhE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfC1LX5 (ORCPT ); Thu, 28 Mar 2019 07:23:57 -0400 Received: from mail-eopbgr30044.outbound.protection.outlook.com ([40.107.3.44]:33107 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725779AbfC1LX5 (ORCPT ); Thu, 28 Mar 2019 07:23:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqZFUD5YSePBlQ6/qSWoRB4yE9lUEcSItmYT4c/ZwJE=; b=X4jbNwhE4bnCs6bSRU2WTkofAY72hb2q5m2lLbnDSohmWKivEppP+CmyzxvKX1qJ4UxtgTQjt48pUeFfr+JTQwLXDKapNEpFaJGFOPaHdUCD3P7pZWHM7g0ntk9z845fSc8DOMOEnO3ZubxKCfo7v1z3z7jTNm3O0dDXq0vr4kk= Received: from AM0PR05MB6100.eurprd05.prod.outlook.com (20.178.119.209) by AM0PR05MB6292.eurprd05.prod.outlook.com (20.179.32.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Thu, 28 Mar 2019 11:23:53 +0000 Received: from AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9]) by AM0PR05MB6100.eurprd05.prod.outlook.com ([fe80::85ee:723:721e:51f9%4]) with mapi id 15.20.1730.019; Thu, 28 Mar 2019 11:23:53 +0000 From: Ido Schimmel To: David Ahern CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , David Ahern Subject: Re: [PATCH v3 net-next 13/13] net: Use common nexthop init and release helpers Thread-Topic: [PATCH v3 net-next 13/13] net: Use common nexthop init and release helpers Thread-Index: AQHU5RpFm4Ey59q0T0Knn6RI8EapK6Yg5zuA Date: Thu, 28 Mar 2019 11:23:53 +0000 Message-ID: <20190328112351.GE19672@splinter> References: <20190328035358.4929-1-dsahern@kernel.org> <20190328035358.4929-14-dsahern@kernel.org> In-Reply-To: <20190328035358.4929-14-dsahern@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0052.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::16) To AM0PR05MB6100.eurprd05.prod.outlook.com (2603:10a6:208:12e::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd16ddd6-263b-4668-78d8-08d6b36fdbf3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM0PR05MB6292; x-ms-traffictypediagnostic: AM0PR05MB6292: x-microsoft-antispam-prvs: x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(136003)(346002)(366004)(39860400002)(376002)(189003)(199004)(14454004)(7736002)(486006)(11346002)(26005)(186003)(446003)(4326008)(25786009)(6246003)(476003)(9686003)(305945005)(5660300002)(6116002)(6512007)(97736004)(229853002)(8936002)(86362001)(6436002)(33716001)(3846002)(256004)(105586002)(1076003)(102836004)(386003)(316002)(4744005)(6486002)(6506007)(66066001)(478600001)(33656002)(2906002)(71200400001)(99286004)(71190400001)(8676002)(53936002)(52116002)(81156014)(6916009)(76176011)(81166006)(106356001)(68736007)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR05MB6292;H:AM0PR05MB6100.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HT4NOltJk5qOCysqdNOZTvlqb633py+IGMYNqRdL1PApYM1944gauOumfZfBTxbGC+iD9VljEFJp1wl0vWpC7zAdSVOJYEoy3a4ijL/Lt5Ho43dvdY1ryeebQPgzRxrKHWBb0CsaDC+nRdsU6CGeGRjDIYU1vli2R7UBvWIjlAegqC5ZIsnXjArb0Vj5TjHuCa7lX6Bc8N9z6OnS6S/qt19mHFGSRLedfKV6FXKfWROq5dr5vWRC6gEKxbssVisoktbXat6UT7DjLqCgNmMWXXywoDLe+nBoYIehoW8r1cn/5H+ND0G1F6a7tT60ioIwpO7oO6YsZ3KsYkq85yYuFcN9XUraM6/PaSIpskdM6BgEwmt4P5HD66+hHznhsa697Ua7s7Ww9Yp8EX1e4jMgI3PphsXXf/HTnaVIaS4tFgU= Content-Type: text/plain; charset="us-ascii" Content-ID: <2A2D2C81DEC2754096F97A0633123F88@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd16ddd6-263b-4668-78d8-08d6b36fdbf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 11:23:53.4943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6292 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 27, 2019 at 08:53:58PM -0700, David Ahern wrote: > From: David Ahern >=20 > With fib_nh_common in place, move common initialization and release > code into helpers used by both ipv4 and ipv6. For the moment, the init > is just the lwt encap and the release is both the netdev reference and > the the lwt state reference. More will be added later. >=20 > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel