From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F728C43381 for ; Thu, 28 Mar 2019 21:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 495EB21850 for ; Thu, 28 Mar 2019 21:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="xP3MXLLW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727493AbfC1VkJ (ORCPT ); Thu, 28 Mar 2019 17:40:09 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41849 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbfC1VkI (ORCPT ); Thu, 28 Mar 2019 17:40:08 -0400 Received: by mail-qk1-f194.google.com with SMTP id o129so188508qke.8 for ; Thu, 28 Mar 2019 14:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=FaflBRosIgxjpzvi9dIZCuSpZIrD5q5e5KLpJ+ks9sk=; b=xP3MXLLWPmvEcPsx9lckJSL3UP+LAEgobxA6ADb59QUcRAubvu3ZwQ0FxEUwG4JRTX sC4K/0YzHu1qKxGF4kjW2AJv22EtqShQYecJ6JsXijXYjpneiFfvEJnFSv9/2N5JcHdR 6VG1PMh0MULLJW9eG/S88nrAH0KyDSwdvkjAS49gsfC1LQnhftS3FKvZEvuM9rwAgmww VzI4q7H/N0lJqpx012KIWm9kPRIoh09z1wjEwdPjAldMPlwBQ/BCg/O2Fl6bQBXiSO+X MFeQTT3ZYgnLs2QxNMuvYynZ5M/EAEryhsd+BzzafFEBBksIu3F0SSGnLPtph5lCDH4M okBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=FaflBRosIgxjpzvi9dIZCuSpZIrD5q5e5KLpJ+ks9sk=; b=rXpymapGGOZFWdTxH2wjf3lvFvE4U8eiO/TWws+lvC5y2lXzxmB+QnanNImja+Co0z OWz1VGJr+BFit3dZ+StQTGNhwdkqwAU3Bb+yG2/iB5J130RdK3k7Os+fibQMgp+/dY4q MAja31VdWJAhFRyh754ZPnKoIu/Yv6JhuVZ5I/RuAdxApKRLe/+xby10PJoGjovC9kNq wEZTAp2N6WSN8z18cpghROOJyFiPpPBy2Rjwi/SeRuacnXuhIMasVK6wxG844yucZUOv 81T/RQ4DahP7XGXzz7oy9oCFv4HUHAEjEAv6rtVzWAJL6s4GsIoon/9wDWfzpjbaRkfB pgpQ== X-Gm-Message-State: APjAAAWcS4tjlAm7YqU/nW5YFBXrYTy6Z66SfhSW1S8OhG/3Ghz4XFmH zce4/vyhn73LmowpjmQKSqAmdw== X-Google-Smtp-Source: APXvYqzbyALQHcrndDWSi8jwFXFPojMJC7WduDMgagbuQ5KqAAExvxy3r7AZ9BKcUxkBAZlP50FuBg== X-Received: by 2002:a37:4909:: with SMTP id w9mr34928996qka.109.1553809207458; Thu, 28 Mar 2019 14:40:07 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y197sm142159qkb.23.2019.03.28.14.40.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 14:40:07 -0700 (PDT) Date: Thu, 28 Mar 2019 14:40:02 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink Message-ID: <20190328144002.245c9eef@cakuba.netronome.com> In-Reply-To: <20190328211254.1894-1-jiri@resnulli.us> References: <20190328211254.1894-1-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Mar 2019 22:12:42 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > To provide visibility of the ports, this patchset exposes switch ID > for devlink ports, which are part of a switch. The rest of the ports > if any (in case of sr-iov for example) do not set switch ID. I don't feel good about this patch set. There is no visibility provided here. Should the port flavour should be a sufficient indication of whether netdev associated with that port can be switched to or not? CPU, DSA, and Host flavours can't be switched to. And the switchid can be an attribute of the devlink instance, if we want to expose it via devlink.