From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB97C43381 for ; Fri, 29 Mar 2019 00:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3981A21871 for ; Fri, 29 Mar 2019 00:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="kuAA9hSQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbfC2A14 (ORCPT ); Thu, 28 Mar 2019 20:27:56 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:45280 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727948AbfC2A14 (ORCPT ); Thu, 28 Mar 2019 20:27:56 -0400 Received: by mail-qt1-f195.google.com with SMTP id v20so430687qtv.12 for ; Thu, 28 Mar 2019 17:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=2Hp5LawU6wMnhaFFDAyqK6JTyfr6IYOZd8LYUAd41AY=; b=kuAA9hSQhWlBYlH0qsoZ83WK5aZT1a5Ryh5AFCWevRwVkUH8909VHUKlBsJiXT9tb4 mMxT20ezBKN2aCOBP9EPwyYEmujX6AtT13G/aB7siEZMu4VuLhB/cbI4eDXApKGn0UZ+ eQ3MSZ5tcQkniG/cFW9uRqdToiJ7X9/HDJP5fsT1HMvhl+/A7vEmTCi7VXvQBr9Ex1bZ wblbsA6Zfj2U2yN6X3aeIqbRJidmh0ifqyllTAeB9GKpHRIvr23MF1jG66+fx1xxyFxN u9XkILHX5iwsmI4bBYgqblVuX0CJxM6m1+dQrOu5m4DtcZuxlHHPLvrkxTMBdslNjfB1 je7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=2Hp5LawU6wMnhaFFDAyqK6JTyfr6IYOZd8LYUAd41AY=; b=pv1ZjP11CDeykbn94vbwjp1k/yR6o50gDa602wH078qAf3JysBCFCBWZj3AmDop6MF E46+cR9bXe7zSRXQa2G6W3JVMFrwVgGaOY4AkDbKiQuhUhc4TaZfsNNgqOh2M8MR/iUu vBUYl4JN0pBlzvwBxkXLA49RIfnt+7HRic8xRYLCdNLSQfIrIxrsYRru4If7wce7yDoi RsQLgwv5q3O/06uLjl9za4dUiegHr5VDIcECvj1la87IhqChdMvmGYhalGWc/DsjNG1Y /x8c71wHbtdSYAs2qpskigA5fIieV8V3K0IdexUmuKH7UN/5QCebgfNokhKZYgeLcSCo SDWw== X-Gm-Message-State: APjAAAWE9V1JAwWUB3zoFhmoulI61xXE5KcNTpyIugG8y7AWF9Oo06cT vvZGDMLx5zvideqA87gA+8VGaA== X-Google-Smtp-Source: APXvYqx3hjkv/cbKUmXZra72yt5iym5bQ+3hU5BK50r8+HnBQCcMF1CC+66VAZ/dzbSvHPMGrO3xIg== X-Received: by 2002:a0c:bd2d:: with SMTP id m45mr32884822qvg.229.1553819274985; Thu, 28 Mar 2019 17:27:54 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id x14sm305438qtc.44.2019.03.28.17.27.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 17:27:54 -0700 (PDT) Date: Thu, 28 Mar 2019 17:27:50 -0700 From: Jakub Kicinski To: David Miller Cc: oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH net 0/2] nfp: fix retcode and disable netpoll on representors Message-ID: <20190328172750.05e30c6c@cakuba.netronome.com> In-Reply-To: <20190328.170453.1247086248564076817.davem@davemloft.net> References: <20190327183839.18889-1-jakub.kicinski@netronome.com> <20190328.170453.1247086248564076817.davem@davemloft.net> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Mar 2019 17:04:53 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Wed, 27 Mar 2019 11:38:37 -0700 > > > This series avoids a potential crash on nfp representor devices > > when netpoll is in use. If transmitting the frame through underlying > > vNIC fails we'd return an error code (by passing on error code from > > __dev_queue_xmit()) and cause double free in netpoll code. > > > > Fix the error code and disable netpoll on reprs altogether. > > IRQ-safety of locking the queues and calling __dev_queue_xmit() > > is questionable. > > > > Big thanks to John Hurley for debugging and narrowing down > > the trace log after I gave up! :) > > Series applied, thanks Jakub. > > Want me to queue these up for -stable? Mm.. yes, I think so, patch 1 can lead to a hard to catch double free. Thanks!