From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] ethtool: add PHY Fast Link Down tunable to man page
Date: Thu, 28 Mar 2019 21:01:03 +0100 [thread overview]
Message-ID: <20190328200103.GC5446@lunn.ch> (raw)
In-Reply-To: <2ca651c7-89b3-65fd-0941-b732692c8d41@gmail.com>
> + Sets the period after which the link is reported as down. Note that the PHY may choose
> + the closest supported value. Only on reading back you get the actual value.
Hi Heiner
'Only on reading back the tunable do you get the actual value.'
would be better.
> .TE
> .PD
> .RE
> @@ -1090,6 +1106,14 @@ Link speed downshift after N failed 1000BASE-T auto-negotiation attempts.
> Downshift is useful where cable does not have the 4 pairs instance.
>
> Gets the PHY downshift count/status.
> +.TP
> +.B fast\-link\-down
> +Depending on the mode it may take 0.5s - 1s until a broken link is reported as down.
> +In certain use cases a link-down event needs to be reported as soon as possible.
> +Some PHYs support a Fast Link Down feature, and partially even allow to configure
> +the period until until a broken link is reported as being down.
Some PHYs support a Fast Link Down Feature and may allow configuration
of the delay before a broken link is reported as being down.
Andrew
next prev parent reply other threads:[~2019-03-28 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 19:25 [PATCH 0/4] ethtool: add support for new PHY tunable Fast Link Down Heiner Kallweit
2019-03-28 19:26 ` [PATCH 1/4] ethtool: sync ethtool-copy.h with linux-next from 03/28/2019 Heiner Kallweit
2019-03-28 19:27 ` [PATCH 2/4] ethtool: simplify handling of PHY tunable downshift Heiner Kallweit
2019-03-28 19:27 ` [PATCH 3/4] ethtool: add support for PHY tunable Fast Link Down Heiner Kallweit
2019-03-28 19:28 ` [PATCH 4/4] ethtool: add PHY Fast Link Down tunable to man page Heiner Kallweit
2019-03-28 20:01 ` Andrew Lunn [this message]
2019-03-28 20:12 ` Heiner Kallweit
2019-03-29 14:19 ` John W. Linville
2019-03-29 18:54 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328200103.GC5446@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).