From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=nMjf=SA=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 41C18C43381
	for <netdev@archiver.kernel.org>; Fri, 29 Mar 2019 17:53:27 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1C55F218A3
	for <netdev@archiver.kernel.org>; Fri, 29 Mar 2019 17:53:27 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729880AbfC2RxQ (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 29 Mar 2019 13:53:16 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:53900 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729762AbfC2RxQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 29 Mar 2019 13:53:16 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 0E12414EF985A;
        Fri, 29 Mar 2019 10:53:15 -0700 (PDT)
Date:   Fri, 29 Mar 2019 10:53:14 -0700 (PDT)
Message-Id: <20190329.105314.682397988670279152.davem@davemloft.net>
To:     dsahern@kernel.org
Cc:     netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com,
        saeedm@mellanox.com, dsahern@gmail.com
Subject: Re: [PATCH v3 net-next 00/13] net: Move fib_nh and fib6_nh to a
 common struct
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190328035358.4929-1-dsahern@kernel.org>
References: <20190328035358.4929-1-dsahern@kernel.org>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 29 Mar 2019 10:53:15 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: David Ahern <dsahern@kernel.org>
Date: Wed, 27 Mar 2019 20:53:45 -0700

> From: David Ahern <dsahern@gmail.com>
> 
> First set of three with the end goal of enabling IPv6 gateways with IPv4
> routes.
> 
> This set refactors ipv4 and ipv6 code to create init and release
> helpers for each protocol and moving common elements to a fib_nh_common
> struct.
> 
> v3
> - split the reject setting into 2 with helper to the checks. This
>   avoids changing cfg->fc_flags in fib6_nh_init
> 
> v2
> - addressed Ido's comments: cleanup on failure path in nh_init helpers,
>   ordering in fib6_nh_release, and removal of RTF_GATEWAY from fib6_info
>   uses in mlxsw

Looks great, series applied, thanks David.