From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0231C43381 for ; Mon, 1 Apr 2019 18:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77A5920663 for ; Mon, 1 Apr 2019 18:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730553AbfDASGF (ORCPT ); Mon, 1 Apr 2019 14:06:05 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32950 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730447AbfDARND (ORCPT ); Mon, 1 Apr 2019 13:13:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1117014B8AF65; Mon, 1 Apr 2019 10:13:03 -0700 (PDT) Date: Fri, 29 Mar 2019 13:26:25 -0700 (PDT) Message-Id: <20190329.132625.1337964193492368096.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/3] net: phy: add and use new function genphy_read_abilities From: David Miller In-Reply-To: <3d087449-a68f-8233-e97f-29038f8de29a@gmail.com> References: <3d087449-a68f-8233-e97f-29038f8de29a@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 10:13:03 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Wed, 27 Mar 2019 21:57:10 +0100 > Similar to genphy_c45_pma_read_abilities() add a function to dynamically > detect the abilities of a Clause 22 PHY. This is mainly copied from > genphy_config_init(). Main benefit is that PHY drivers no longer have > to specify whether they support GBit or not (provided they keep to > the C22 standard). This looks great to me. Andrew/Florian, please review. Thanks.