From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
borisp@mellanox.com, davejwatson@fb.com, vakul.garg@nxp.com,
simon.horman@netronome.com
Subject: Re: [PATCH net] net: tls: prevent false connection termination with offload
Date: Fri, 29 Mar 2019 13:39:41 -0700 (PDT) [thread overview]
Message-ID: <20190329.133941.1073614751791804879.davem@davemloft.net> (raw)
In-Reply-To: <20190328215443.9989-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 28 Mar 2019 14:54:43 -0700
> Only decrypt_internal() performs zero copy on rx, all paths
> which don't hit decrypt_internal() must set zc to false,
> otherwise tls_sw_recvmsg() may return 0 causing the application
> to believe that that connection got closed.
>
> Currently this happens with device offload when new record
> is first read from.
>
> Fixes: d069b780e367 ("tls: Fix tls_device receive")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>
Applied, thanks Jakub.
prev parent reply other threads:[~2019-04-01 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 21:54 [PATCH net] net: tls: prevent false connection termination with offload Jakub Kicinski
2019-03-28 22:01 ` Jakub Kicinski
2019-03-29 20:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329.133941.1073614751791804879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).