From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3150C43381 for ; Mon, 1 Apr 2019 17:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA00F21925 for ; Mon, 1 Apr 2019 17:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730468AbfDARNG (ORCPT ); Mon, 1 Apr 2019 13:13:06 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730459AbfDARNE (ORCPT ); Mon, 1 Apr 2019 13:13:04 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 797D914B8AF68; Mon, 1 Apr 2019 10:13:04 -0700 (PDT) Date: Fri, 29 Mar 2019 13:39:41 -0700 (PDT) Message-Id: <20190329.133941.1073614751791804879.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, borisp@mellanox.com, davejwatson@fb.com, vakul.garg@nxp.com, simon.horman@netronome.com Subject: Re: [PATCH net] net: tls: prevent false connection termination with offload From: David Miller In-Reply-To: <20190328215443.9989-1-jakub.kicinski@netronome.com> References: <20190328215443.9989-1-jakub.kicinski@netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 10:13:04 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Thu, 28 Mar 2019 14:54:43 -0700 > Only decrypt_internal() performs zero copy on rx, all paths > which don't hit decrypt_internal() must set zc to false, > otherwise tls_sw_recvmsg() may return 0 causing the application > to believe that that connection got closed. > > Currently this happens with device offload when new record > is first read from. > > Fixes: d069b780e367 ("tls: Fix tls_device receive") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Applied, thanks Jakub.