From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1179C43381 for ; Fri, 29 Mar 2019 15:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0CC82184C for ; Fri, 29 Mar 2019 15:15:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="yYZEpLle" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729097AbfC2PPR (ORCPT ); Fri, 29 Mar 2019 11:15:17 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37619 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728720AbfC2PPR (ORCPT ); Fri, 29 Mar 2019 11:15:17 -0400 Received: by mail-pl1-f196.google.com with SMTP id q6so1189205pll.4 for ; Fri, 29 Mar 2019 08:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8p5GIdkfbRVojjrBSjpcItebYlf6JsSZYGwk3/z/dmo=; b=yYZEpLleqJcg6+aQWb9Tdfg/nlI2UdpSmXKTpwqGRSzrTKh21w5Ic5vwYxoi2LWN4a LsDJPfQzdr6OfxpHZJWOYGXkzoLEFrclV3cS6Q/bNtJFFNOmDx9DDTUqVAbgABT5VBIN HU9QRFGOEMoaC8vzMdUvy536QCWuvk6WlGPKKheL/FBTyBMQ4abUa8lyISNO2VNylrPC R8Yo8Jw7+GRScRfIaqnjapfagDXKAT/79kYrrqWTFZktc3EI83ieLq1kJtZdi6ourppi A3YuusSVQ+jaAa2Dr7fTlulfMx4esw3NWLJ8Ev7SbWaf8OJtNUXauO1mRC95WYilMdiu Kplw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8p5GIdkfbRVojjrBSjpcItebYlf6JsSZYGwk3/z/dmo=; b=PCtlfUZ/CJmzFG01nsFHzJIx78M3vU5C3PVkibgTxaUVku7/OHqK1O6ZGsDL0nbDvK uVmmdo+jl8UbNSuMUNOktyAU6q56VIfExVqPccyGVuYXnQaYi9vBt/dH4DF2swByY5OC fBNb2U77NhKI5q5Z62+Y8b2djgXLlAez13ZZa1YFEOYb5X8aiXJRMwtvIEz+HexAz0Ft xnfD9Vz9Lv29Z3PelbBwiiXGqIlMHqY3NIDSaQ7h6W9c36qC9FgqVY+V1a39LCRAiH/Z AIPv9TffE+mCZQglJfyRjvXTGvCnGpZ9oIiVc3a6Gd5b3QILPdiAT8SoWBPJNWBoLTAM yPAw== X-Gm-Message-State: APjAAAX1uttgy3S6YiiyVeIvBQtU5j/9AWSRdEGSCpyTEtSYEr4ob9ZB E9aH41D3b02ItmJOKmsD2PIteg== X-Google-Smtp-Source: APXvYqzG/1OK1a8N2CD6yV8ZSU0yctBddvg455yKQiIMoTribzVRQBGynWnbZKyroZ2IQ6YugmaWPA== X-Received: by 2002:a17:902:2865:: with SMTP id e92mr50218227plb.312.1553872515932; Fri, 29 Mar 2019 08:15:15 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f192sm4435291pfc.180.2019.03.29.08.15.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:15:15 -0700 (PDT) Date: Fri, 29 Mar 2019 08:15:12 -0700 From: Stephen Hemminger To: Si-Wei Liu Cc: mst@redhat.com, sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190329081512.2f231508@shemminger-XPS-13-9360> In-Reply-To: <1553816847-28121-1-git-send-email-si-wei.liu@oracle.com> References: <1553816847-28121-1-git-send-email-si-wei.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Mar 2019 19:47:27 -0400 Si-Wei Liu wrote: > + if (unlikely(dev->flags & IFF_UP)) { > + struct netdev_notifier_change_info change_info; > + > + change_info.flags_changed = 0; Simpler to use structure initialization, which also avoid any chance of unititialized fields. struct netdev_notifier_change_info change_info = { .flags_changed = 0 };