From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088F2C43381 for ; Fri, 29 Mar 2019 14:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA9D22173C for ; Fri, 29 Mar 2019 14:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728903AbfC2Oax (ORCPT ); Fri, 29 Mar 2019 10:30:53 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:42863 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728652AbfC2Oax (ORCPT ); Fri, 29 Mar 2019 10:30:53 -0400 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1h9sWs-0005QO-5O; Fri, 29 Mar 2019 10:30:47 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x2TEJYh1009023; Fri, 29 Mar 2019 10:19:34 -0400 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x2TEJXVI009021; Fri, 29 Mar 2019 10:19:33 -0400 Date: Fri, 29 Mar 2019 10:19:33 -0400 From: "John W. Linville" To: Heiner Kallweit Cc: Andrew Lunn , Florian Fainelli , "netdev@vger.kernel.org" Subject: Re: [PATCH 4/4] ethtool: add PHY Fast Link Down tunable to man page Message-ID: <20190329141933.GB6686@tuxdriver.com> References: <7abec5a5-8087-8591-8619-83605de6dddc@gmail.com> <2ca651c7-89b3-65fd-0941-b732692c8d41@gmail.com> <20190328200103.GC5446@lunn.ch> <2e35b458-1846-4e58-0cb1-953c2df76709@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e35b458-1846-4e58-0cb1-953c2df76709@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 28, 2019 at 09:12:45PM +0100, Heiner Kallweit wrote: > On 28.03.2019 21:01, Andrew Lunn wrote: > >> + Sets the period after which the link is reported as down. Note that the PHY may choose > >> + the closest supported value. Only on reading back you get the actual value. > > > > Hi Heiner > > > > 'Only on reading back the tunable do you get the actual value.' > > > > would be better. > > > OK. I'll wait for more review feedback and will consider this in a v2. > Currently all mails to John are bounced due to some spam filter rejecting mails from > Google servers, so let's see when he reads this. I'm having some mail server problems right now, but I got this message... ;-) I like Andrew's wording suggestions, FWIW. Should I expect a repost? John > >> .TE > >> .PD > >> .RE > >> @@ -1090,6 +1106,14 @@ Link speed downshift after N failed 1000BASE-T auto-negotiation attempts. > >> Downshift is useful where cable does not have the 4 pairs instance. > >> > >> Gets the PHY downshift count/status. > >> +.TP > >> +.B fast\-link\-down > >> +Depending on the mode it may take 0.5s - 1s until a broken link is reported as down. > >> +In certain use cases a link-down event needs to be reported as soon as possible. > >> +Some PHYs support a Fast Link Down feature, and partially even allow to configure > >> +the period until until a broken link is reported as being down. > > > > Some PHYs support a Fast Link Down Feature and may allow configuration > > of the delay before a broken link is reported as being down. > > > OK > > > Andrew > > > Heiner > > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.