From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEBBBC43381 for ; Sat, 30 Mar 2019 19:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D8492183F for ; Sat, 30 Mar 2019 19:49:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="uvHLnF6e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730953AbfC3Tt3 (ORCPT ); Sat, 30 Mar 2019 15:49:29 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43612 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730542AbfC3Tt3 (ORCPT ); Sat, 30 Mar 2019 15:49:29 -0400 Received: by mail-pl1-f194.google.com with SMTP id m10so2554231plt.10 for ; Sat, 30 Mar 2019 12:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=IZZGeOcLGzPHyOQdsDW0wBjiKm1PC6D3mwS8sDWzHfw=; b=uvHLnF6erQTaThaNt2Y+NeZW8le0aXeJXiz15dcudTMSDXVace8PH1a3uSTi5oQQTN eEVS9/acFCFIf0Cl3Xk+w/S/3LWsf0B0AEua2QTR5N/1daKd8KrFf/NVb1JjBFLe/L5O xr+pFrTC9YMSx4y0S6sYMBa4Jf0p/kzHJYtw9m7ljSAMDMCxuszV2CORUILab0tA3kyz Sv21mO2AKc/L9KlSCY7Kfc8N/tgonKAUePDQZhl8QFK8bWByq0jjgTMiMiebzKag6VVs 6dSNH27oGbdrusXkjlL2BpXm+jOBo6g68obFzktHRNgqeFE+NbupMNb558uD3SBXzVEk wyxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=IZZGeOcLGzPHyOQdsDW0wBjiKm1PC6D3mwS8sDWzHfw=; b=F58fxA7oEwUQAIu2mXT2olmvImGgzVj7vWaALLJsvAoUrnXzd7UGRDYCMyDvRjoPEI PdRgEIbUJCTi82FiEEjlRsX0I51Ep+WD7iS/TIjLc7Wwh0EpguhcGcrw4fHeUBwt0TxG HiEoqkoiyWXBiIneDQpilsGPkSITDm46PJ49r1yBR/6tputfUp432Q/XEI4TmyVUTy12 f5Na5Gpy7eo8nmN+4v01M5ZGz7H8RpZuAqi1NBavTibiYL3vzwYenslW56HLr2OvvcxG DHo0seNYbwPWH+8hioWaFq6Bb/tjNuSyeJ5SNDT3CfoYR7Tz8xXjnww1O/ixP0l12bbx +6NQ== X-Gm-Message-State: APjAAAU36YlqmJz/Hwxif5yb8W86a1uTfs07uM2KoG6rFeiQLxt3N+LT 24oi3bMLvPGHDPTm1AM5ohhk9w== X-Google-Smtp-Source: APXvYqzh4VpJFBVS5X6pulvaHLw4e6dKQu+MmwZf2P/co8zWfSu9A8rSVLwuhdGdDhm6AvwHJAkM3Q== X-Received: by 2002:a17:902:2927:: with SMTP id g36mr28028624plb.57.1553975368258; Sat, 30 Mar 2019 12:49:28 -0700 (PDT) Received: from cakuba.hsd1.ca.comcast.net ([2601:646:8e00:1b7a::2]) by smtp.gmail.com with ESMTPSA id m69sm8205548pfi.151.2019.03.30.12.49.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Mar 2019 12:49:27 -0700 (PDT) Date: Sat, 30 Mar 2019 12:49:23 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: Linux Netdev List , David Miller , mlxsw@mellanox.com, Ido Schimmel , Florian Fainelli , Andrew Lunn , vivien.didelot@gmail.com, Michael Chan , Or Gerlitz Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink Message-ID: <20190330124923.300e6759@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190330073527.GB14297@nanopsycho> References: <20190328211254.1894-1-jiri@resnulli.us> <20190328144002.245c9eef@cakuba.netronome.com> <20190329064905.GS14297@nanopsycho> <20190329115926.5c16d2fd@cakuba.netronome.com> <20190329212153.GA14297@nanopsycho> <20190330073527.GB14297@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 30 Mar 2019 08:35:27 +0100, Jiri Pirko wrote: >> Is switchib doing forwarding? Not long ago Parav was convincing us >> that switchdev mode for IB is pretty much meaningless. Even though >> there are apparently representors for IB (judging by the recent RDMA >> patchset on netdev)... > > Switch id is simply identifier for ports in general that belong to some > switch. No matter if ethernet or IB. IIUC functionally there are two uses for switch ID: (1) bridging code and flower offloads making forwarding decisions; (2) naming the netdevs of the same switch with udev rules (sw$id$port). Meta use: - logically grouping netdevs so that user space knows how (1) and (2) will behave. Devlink ports are already grouped under the devlink instance, and they not involved in forwarding decisions. We should add functionality when we have evidence it's going to be useful. I don't see how devlink needs switch id, in any way. Sure, the internal code reshuffle is a matter of taste, but for exposing switch id on devlink ports, I see _no_ reason. I think this makes my position clear :) I don't really enjoy disagreeing with people, and neither do I care about this particularly strongly, so please consider what I said, and if that doesn't convince you feel free to add my review tag on the nfp patches :)