From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996A6C43381 for ; Sun, 31 Mar 2019 18:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6729920872 for ; Sun, 31 Mar 2019 18:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731353AbfCaSNV (ORCPT ); Sun, 31 Mar 2019 14:13:21 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730662AbfCaSNU (ORCPT ); Sun, 31 Mar 2019 14:13:20 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 62C6114F14B43; Sun, 31 Mar 2019 11:13:20 -0700 (PDT) Date: Sun, 31 Mar 2019 11:13:20 -0700 (PDT) Message-Id: <20190331.111320.1948640028158399763.davem@davemloft.net> To: hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168 From: David Miller In-Reply-To: <23289428-64e1-206c-385e-b1ce9c4cc14c@gmail.com> References: <23289428-64e1-206c-385e-b1ce9c4cc14c@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 31 Mar 2019 11:13:20 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sun, 31 Mar 2019 15:43:59 +0200 > @@ -5456,12 +5448,6 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp) > { > RTL_W8(tp, MaxTxPacketSize, TxPacketMax); > > - tp->cp_cmd &= ~INTT_MASK; > - tp->cp_cmd |= PktCntrDisable | INTT_1; > - RTL_W16(tp, CPlusCmd, tp->cp_cmd); > - > - RTL_W16(tp, IntrMitigate, 0x5100); > - > /* Work around for RxFIFO overflow. */ This patch isn't against net-next. I'm guessing it's against a tree with the RX coalesce disable changes applied.