From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
vivien.didelot@gmail.com,
Michael Chan <michael.chan@broadcom.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink
Date: Sun, 31 Mar 2019 10:50:17 +0200 [thread overview]
Message-ID: <20190331085017.GB2168@nanopsycho> (raw)
In-Reply-To: <20190330124923.300e6759@cakuba.hsd1.ca.comcast.net>
Sat, Mar 30, 2019 at 08:49:23PM CET, jakub.kicinski@netronome.com wrote:
>On Sat, 30 Mar 2019 08:35:27 +0100, Jiri Pirko wrote:
>>> Is switchib doing forwarding? Not long ago Parav was convincing us
>>> that switchdev mode for IB is pretty much meaningless. Even though
>>> there are apparently representors for IB (judging by the recent RDMA
>>> patchset on netdev)...
>>
>> Switch id is simply identifier for ports in general that belong to some
>> switch. No matter if ethernet or IB.
>
>IIUC functionally there are two uses for switch ID:
> (1) bridging code and flower offloads making forwarding decisions;
> (2) naming the netdevs of the same switch with udev rules (sw$id$port).
>Meta use:
> - logically grouping netdevs so that user space knows how (1) and (2)
> will behave.
>
>Devlink ports are already grouped under the devlink instance, and they
>not involved in forwarding decisions.
>
>We should add functionality when we have evidence it's going to be
>useful. I don't see how devlink needs switch id, in any way. Sure,
>the internal code reshuffle is a matter of taste, but for exposing
>switch id on devlink ports, I see _no_ reason.
>
>I think this makes my position clear :) I don't really enjoy
>disagreeing with people, and neither do I care about this particularly
>strongly, so please consider what I said, and if that doesn't convince
>you feel free to add my review tag on the nfp patches :)
I understand that from the functionality point of view, you are correct.
But for the visibility and better understanding about what's the
topology, I think it would be fine to expose this. Anyway, I'll remove
the patch to expose the devlink ATTR for now. Let's see how things are
going to look after we do the rest.
next prev parent reply other threads:[~2019-03-31 8:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 21:12 [patch net-next 00/12] net: expose switch ID via devlink Jiri Pirko
2019-03-28 21:12 ` [patch net-next 01/12] net: devlink: convert devlink_port_attrs bools to bits Jiri Pirko
2019-03-28 21:12 ` [patch net-next 02/12] net: devlink: extend port attrs for switch ID Jiri Pirko
2019-03-28 21:12 ` [patch net-next 03/12] net: devlink: introduce devlink_compat_switch_id_get() helper Jiri Pirko
2019-03-28 21:12 ` [patch net-next 04/12] mlxsw: Pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-28 21:12 ` [patch net-next 05/12] mlxsw: Remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-28 21:12 ` [patch net-next 06/12] bnxt: pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-28 21:12 ` [patch net-next 07/12] bnxt: remove ndo_get_port_parent_id implementation for physical ports Jiri Pirko
2019-03-28 21:12 ` [patch net-next 08/12] nfp: pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-28 21:12 ` [patch net-next 09/12] nfp: remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-28 21:12 ` [patch net-next 10/12] mlxsw: switch_ib: Pass valid HW id down to mlxsw_core_port_init() Jiri Pirko
2019-03-28 21:12 ` [patch net-next 11/12] dsa: pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-29 21:59 ` Florian Fainelli
2019-04-01 13:04 ` Jiri Pirko
2019-03-28 21:12 ` [patch net-next 12/12] net: devlink: add warning for ndo_get_port_parent_id set when not needed Jiri Pirko
2019-03-28 21:40 ` [patch net-next 00/12] net: expose switch ID via devlink Jakub Kicinski
2019-03-29 6:49 ` Jiri Pirko
2019-03-29 18:59 ` Jakub Kicinski
2019-03-29 21:21 ` Jiri Pirko
2019-03-29 22:34 ` Jakub Kicinski
2019-03-30 7:35 ` Jiri Pirko
2019-03-30 19:49 ` Jakub Kicinski
2019-03-31 8:50 ` Jiri Pirko [this message]
2019-03-31 20:57 ` Jakub Kicinski
2019-03-29 21:29 ` Florian Fainelli
2019-03-29 21:57 ` Jakub Kicinski
2019-03-29 22:04 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331085017.GB2168@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).