From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B1EC43381 for ; Sun, 31 Mar 2019 08:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67BE22146F for ; Sun, 31 Mar 2019 08:50:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="tx0A4wch" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbfCaIuV (ORCPT ); Sun, 31 Mar 2019 04:50:21 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36959 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfCaIuU (ORCPT ); Sun, 31 Mar 2019 04:50:20 -0400 Received: by mail-wm1-f67.google.com with SMTP id v14so7660309wmf.2 for ; Sun, 31 Mar 2019 01:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DilVNF7daLL40W6+J9vqcf+ngWHBTBbg0ce4Z/58jM4=; b=tx0A4wchNCxmHFLpgRnRs0bEVqDjPN8u5zUuRH3dF5e+MN1G4u+gFjjguAis3AD/kQ MElbtapKmewhmUN4XXs//kcgf+O8jytilNn2e+AY8+/EoaWz6Io2sSSqTqvj7y0kdJ6v oXLkne6pxm/ADRtGTKIg0s8EfMRirPTlVybsL1txseQnHGXiUwz8WOeqT1VxGH9b0ing 10gBD7e3S7pj1s8zO3aW1QzKrUzsSbzGFDhhqc8hdL11ZFgK/9gv9nuGLs++7/5eu8MR +NRnY20oR34OSpxd36bosjirFqe0hHlDXXE+qPLrxVr1nnhdmgU3CmEaxLosIfvXbf2h T4Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DilVNF7daLL40W6+J9vqcf+ngWHBTBbg0ce4Z/58jM4=; b=DeXz3jCFRUmHxI0ZCL/Qx4+Sx7WSnMUJv9J/IozRTFRAmRAtXa0b1DYdxrLhA4cxQs m/sBeb9OkYA+ZdtCdSwwtE4ht5lxuJEYzJWbcBNWmE8Vkh1qOEr24lIYx1jIPruR+Fy+ McCjcQcmnTtUhdARGj43V83iC1cN4S2MswLvF3+rSK/MZD+CyYuA8cgIzw4XmPZU/Ls4 WnOGZYJ48XAT24dP6e4h7jBddA9/VSqMBo7VnDUcjTdyZvoXb9LD9PaC/4g3pJGzZ/jG iQazc768s00dXLwE74GyZyJgBbV3e0Hy0HbVcME/F3gKF5KQp40PU9+IhjBfjqZhS1ME j9WA== X-Gm-Message-State: APjAAAWaUBt7TSg//4MUXfyAMxaoQA4ofJQWqe7ksVoRb+2RNR7geq4U iuN5pa/PUn+kS4/LLfMVYM82CQ== X-Google-Smtp-Source: APXvYqzC/GMaJoXXijnSuaRyxHt23Ovp+mm4zVnFYgI2UzvXX3ffR3UpGwP5tybkSTaXG3wDUivWxw== X-Received: by 2002:a1c:f204:: with SMTP id s4mr9139845wmc.51.1554022218941; Sun, 31 Mar 2019 01:50:18 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id o1sm7933929wmh.47.2019.03.31.01.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Mar 2019 01:50:18 -0700 (PDT) Date: Sun, 31 Mar 2019 10:50:17 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Linux Netdev List , David Miller , mlxsw@mellanox.com, Ido Schimmel , Florian Fainelli , Andrew Lunn , vivien.didelot@gmail.com, Michael Chan , Or Gerlitz Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink Message-ID: <20190331085017.GB2168@nanopsycho> References: <20190328211254.1894-1-jiri@resnulli.us> <20190328144002.245c9eef@cakuba.netronome.com> <20190329064905.GS14297@nanopsycho> <20190329115926.5c16d2fd@cakuba.netronome.com> <20190329212153.GA14297@nanopsycho> <20190330073527.GB14297@nanopsycho> <20190330124923.300e6759@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190330124923.300e6759@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Mar 30, 2019 at 08:49:23PM CET, jakub.kicinski@netronome.com wrote: >On Sat, 30 Mar 2019 08:35:27 +0100, Jiri Pirko wrote: >>> Is switchib doing forwarding? Not long ago Parav was convincing us >>> that switchdev mode for IB is pretty much meaningless. Even though >>> there are apparently representors for IB (judging by the recent RDMA >>> patchset on netdev)... >> >> Switch id is simply identifier for ports in general that belong to some >> switch. No matter if ethernet or IB. > >IIUC functionally there are two uses for switch ID: > (1) bridging code and flower offloads making forwarding decisions; > (2) naming the netdevs of the same switch with udev rules (sw$id$port). >Meta use: > - logically grouping netdevs so that user space knows how (1) and (2) > will behave. > >Devlink ports are already grouped under the devlink instance, and they >not involved in forwarding decisions. > >We should add functionality when we have evidence it's going to be >useful. I don't see how devlink needs switch id, in any way. Sure, >the internal code reshuffle is a matter of taste, but for exposing >switch id on devlink ports, I see _no_ reason. > >I think this makes my position clear :) I don't really enjoy >disagreeing with people, and neither do I care about this particularly >strongly, so please consider what I said, and if that doesn't convince >you feel free to add my review tag on the nfp patches :) I understand that from the functionality point of view, you are correct. But for the visibility and better understanding about what's the topology, I think it would be fine to expose this. Anyway, I'll remove the patch to expose the devlink ATTR for now. Let's see how things are going to look after we do the rest.