From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: dust.li@linux.alibaba.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, caspar@linux.alibaba.com
Subject: Re: [PATCH] tcp: fix a potential NULL pointer dereference in tcp_sk_exit
Date: Mon, 01 Apr 2019 10:12:34 -0700 (PDT) [thread overview]
Message-ID: <20190401.101234.1259757550586433319.davem@davemloft.net> (raw)
In-Reply-To: <CANn89iLAHD1Jkk4xeKUk89s7FPVaBdE5AHu3zNdBZNMn8w8mBw@mail.gmail.com>
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 1 Apr 2019 02:23:39 -0700
> On Mon, Apr 1, 2019 at 1:05 AM dust.li <dust.li@linux.alibaba.com> wrote:
>>
>> From: Dust Li <dust.li@linux.alibaba.com>
>>
>> When tcp_sk_init() failed in inet_ctl_sock_create(),
>> 'net->ipv4.tcp_congestion_control' will be left
>> uninitialized, but tcp_sk_exit() hasn't check for
>> that.
>>
>> This patch add checking on 'net->ipv4.tcp_congestion_control'
>> in tcp_sk_exit() to prevent NULL-ptr dereference.
>>
>> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
>
> Fixes: 6670e1524477 ("tcp: Namespace-ify sysctl_tcp_default_congestion_control")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
This patch didn't make it to the list for whatever reason, but I applied it and
have it queued up for -stable.
Thanks.
prev parent reply other threads:[~2019-04-01 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190401080453.87465-1-dust.li@linux.alibaba.com>
2019-04-01 9:23 ` [PATCH] tcp: fix a potential NULL pointer dereference in tcp_sk_exit Eric Dumazet
2019-04-01 17:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401.101234.1259757550586433319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=caspar@linux.alibaba.com \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).